remove manual wrapping for error table#4035
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Jul 21, 2025
Merged
Conversation
Member
|
Which version of Symfony actually fixed it and do we have it? |
dfef3d4 to
8c74484
Compare
Contributor
Author
|
@ondrejmirtes The comments mention two bugs. One was fixed in v5.4.8, the other was fixed in v5.4.14. PHPStan currently uses v5.4.47, so both fixes should be available. And the screenshots show that the "native" version looks better (at least in the scenarios that I tested). |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two issues mentioned in the comments were fixed years ago. Now it seems that Symfony's wrapping is superior to the PHPStan's.
Motivation:
TableErrorFormatterwhich would put the editor links on the line numbers, instead of showing them separately (I find that distracting). But with the currentErrorConsoleStyleit causes the table to become very narrow, because the hyperlink is included in the computed width of the Line column.Results:
Here are the test files I used to generate the screenshots: