Resolve ExtendedFunctionVariant::getReturnType() more lazily#3966
Draft
ondrejmirtes wants to merge 2 commits into2.1.xfrom
Draft
Resolve ExtendedFunctionVariant::getReturnType() more lazily#3966ondrejmirtes wants to merge 2 commits into2.1.xfrom
ExtendedFunctionVariant::getReturnType() more lazily#3966ondrejmirtes wants to merge 2 commits into2.1.xfrom
Conversation
This will allow the `$this` or `static` in PHPDoc return type to be first replaced with final-overriden ObjectType before being thrown into `TypehintHelper::decideType()`.
5dca10d to
c6fda38
Compare
ondrejmirtes
added a commit
that referenced
this pull request
Apr 29, 2025
ondrejmirtes
pushed a commit
that referenced
this pull request
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the
$thisorstaticin PHPDoc return type to be first replaced with final-overriden ObjectTypebefore being thrown into
TypehintHelper::decideType().