Scope->rememberConstructorScope should not remember the function scope#3944
Merged
ondrejmirtes merged 7 commits intophpstan:2.1.xfrom Apr 18, 2025
Merged
Scope->rememberConstructorScope should not remember the function scope#3944ondrejmirtes merged 7 commits intophpstan:2.1.xfrom
Scope->rememberConstructorScope should not remember the function scope#3944ondrejmirtes merged 7 commits intophpstan:2.1.xfrom
Conversation
This was referenced Apr 18, 2025
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Apr 18, 2025
| public function processNode(Node $node, Scope $scope): array | ||
| { | ||
| if ($scope->getFunction() !== null) { | ||
| throw new ShouldNotHappenException('All names in the tests should not have a scope function.'); |
Member
There was a problem hiding this comment.
"function scope", not "scope function". Function is the adjective here 😊
| } | ||
|
|
||
| return [ | ||
| RuleErrorBuilder::message(sprintf('Name %s found in scope-function null', $node->toString()))->identifier('test.instanceOfMethodsParameterRule')->build(), |
Co-Authored-By: Michal Špaček <1966648+spaze@users.noreply.github.com> Co-Authored-By: Ruud Kamphuis <ruudk@users.noreply.github.com>
Co-Authored-By: Michal Špaček <1966648+spaze@users.noreply.github.com> Co-Authored-By: Ruud Kamphuis <ruudk@users.noreply.github.com>
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When remembering the scope we should not remember the scope-function, as otherwise analyzing instance-method parameters would see the remembered
$scope->getFunction()as__constructinstead ofnull.we only want to remember the types
closes spaze/phpstan-disallowed-calls#323