RegexArrayShapeMatcher - more precise subject types#3897
Merged
ondrejmirtes merged 17 commits intophpstan:2.1.xfrom Mar 24, 2025
Merged
RegexArrayShapeMatcher - more precise subject types#3897ondrejmirtes merged 17 commits intophpstan:2.1.xfrom
ondrejmirtes merged 17 commits intophpstan:2.1.xfrom
Conversation
Contributor
Author
mvorisek
reviewed
Mar 22, 2025
gharlan
reviewed
Mar 22, 2025
85e7b7c to
d43ca1b
Compare
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
Author
|
(errors in nette are valid - expectations need updates) |
Seldaek
reviewed
Mar 24, 2025
Contributor
Seldaek
left a comment
There was a problem hiding this comment.
LGTM from a quick look👍🏻
Contributor
Author
|
awesome, thank you all for reviewing. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#12749
I am aware that we are still not optimal and could be more precise in some cases, but I think its still a solid step forward