Detect accessing static property as non static#3857
Merged
ondrejmirtes merged 4 commits intophpstan:2.1.xfrom Mar 9, 2025
Merged
Detect accessing static property as non static#3857ondrejmirtes merged 4 commits intophpstan:2.1.xfrom
ondrejmirtes merged 4 commits intophpstan:2.1.xfrom
Conversation
ondrejmirtes
requested changes
Mar 6, 2025
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Please do not re-number test lines like that. Put the new test at the bottom of the file. Or even better - add a completely new test method with a completely new test file. It can be testBug12692 / bug-12692.php. Thanks
Co-authored-by: Ondřej Mirtes <ondrej@mirtes.cz>
a2a8633 to
e4acdfa
Compare
Member
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#12692
Thanks to the pointers provided on the issue, I've managed to copy over some bits from the 'reverse' check and adjust them accordingly:
phpstan-src/src/Rules/Properties/AccessStaticPropertiesRule.php
Lines 213 to 228 in 8d4796d
This seems to work fine, but maybe there's still some configuration to be accounted for, given that while incorrect static access will result in a fatal error, incorrect non static access will only emit an info + warning message. As a consequence maybe this check should be considered less critical/important.