Skip to content

Teamcity - show rule identifier when verbose output is set#3804

Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
kamil-zacek:teamcity-show-rule-identifier
Feb 20, 2025
Merged

Teamcity - show rule identifier when verbose output is set#3804
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
kamil-zacek:teamcity-show-rule-identifier

Conversation

@kamil-zacek
Copy link
Copy Markdown
Contributor

Teamcity Code Inspection - show rule identifier for error when verbose output is set

@kamil-zacek
Copy link
Copy Markdown
Contributor Author

@ondrejmirtes i've added rule identifier to teamcity output to show identifier of an error in Teamcity. It should show this identifier in the parentheses when the verbose output is active.

@kamil-zacek kamil-zacek force-pushed the teamcity-show-rule-identifier branch from 0987faa to 4433903 Compare February 3, 2025 12:00
@kamil-zacek kamil-zacek force-pushed the teamcity-show-rule-identifier branch from 4433903 to 095c964 Compare February 18, 2025 12:56
@ondrejmirtes ondrejmirtes merged commit 85ee4f9 into phpstan:2.1.x Feb 20, 2025
435 checks passed
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@jom
Copy link
Copy Markdown

jom commented May 8, 2025

Just a note: The emoji seemed to break the TeamCity parsing of the service message in our instance. I'm working around this for now with a custom error reporter that removes the emoji.

@kamil-zacek
Copy link
Copy Markdown
Contributor Author

Just a note: The emoji seemed to break the TeamCity parsing of the service message in our instance. I'm working around this for now with a custom error reporter that removes the emoji.

Interesting. We don't have the same problem at our teamcity. But it's true that in teamcity the emoji doesn't look as good as at phpstan command line output, so I think there is no problem to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants