More precise constant variants of BooleanType#3781
Merged
ondrejmirtes merged 5 commits intophpstan:2.1.xfrom Jan 11, 2025
Merged
More precise constant variants of BooleanType#3781ondrejmirtes merged 5 commits intophpstan:2.1.xfrom
ondrejmirtes merged 5 commits intophpstan:2.1.xfrom
Conversation
staabm
commented
Jan 11, 2025
|
|
||
| $s = sprintf('%20s', returnsBool()); | ||
| assertType("lowercase-string&non-falsy-string", $s); | ||
| assertType("' '|' 1'", $s); |
Contributor
Author
|
@herndlm opinions? |
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
|
Interesting idea! Makes sense IMO for "finite" types like that |
Contributor
Author
hmm interessting wording you use here. makes me wonder what the semantic difference of
|
Contributor
|
I might be also just mixing up things. Don't even know all those related methods that currently exist on the interface. But good point 🤔 |
Contributor
|
Quickly checked, looks like you could implement that finite method as well here |
Contributor
Author
|
ondrejmirtes
requested changes
Jan 11, 2025
src/Type/BooleanType.php
Outdated
| public function getConstantStrings(): array | ||
| { | ||
| return []; | ||
| return [new ConstantStringType('1'), new ConstantStringType('0')]; |
Member
There was a problem hiding this comment.
Nope. This function isn't used for loose type casts like that.
Member
|
Thank yuo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of resolving bool into true/false in the extension, lets do it in the type-system itself