Fix intval() and floatval() call with a non scalar value#2351
Merged
ondrejmirtes merged 3 commits intophpstan:1.10.xfrom Apr 19, 2023
Merged
Fix intval() and floatval() call with a non scalar value#2351ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
Conversation
If non scalar value is used PHP will throw a warning, not an error like with strval(), so intval/floatval should return int i.e. float type in all cases.
Member
|
Besides this it would also be nice to change the type of intval and floatval parameters to |
Contributor
Author
|
Makes sense. Just added it. The above code now produces a proper error |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a code snippet that shows a misleading error when
intval()is used with a non-scalar.It's reproducible with
checkBenevolentUnionTypes: trueI've traced the issue.
intval()with non-scalar argument resolves toErrorTypewhich is inherited fromMixedType.So
ErrorType::toNumber()returnsUnionType of int and float. When above math expression is resolved it hasinton the left side andfloat|inton the right side which produces error whencheckBenevolentUnionTypesis on.The root cause is fixed in this PR. It adds non-scalar value handling by making sure that return type for intval/floatval in all cases is
inti.e.float.PHP is throwing a warning on use of non-scalar with intval/floatval and not an error like with strval, so even though non-scalar arguments shouldn't be used we should handle them.