Skip to content

Fix incorrect type for NumberFormatter::parseCurrency#2309

Merged
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom
robertvansteen:patch-1
Mar 29, 2023
Merged

Fix incorrect type for NumberFormatter::parseCurrency#2309
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom
robertvansteen:patch-1

Conversation

@robertvansteen
Copy link
Contributor

Just like parse, format and formatCurrency the parseCurrency method can also return false in the case of failure.

https://www.php.net/manual/en/numberformatter.parsecurrency.php

@ondrejmirtes ondrejmirtes merged commit 0d2980a into phpstan:1.10.x Mar 29, 2023
@ondrejmirtes
Copy link
Member

Thank you!

@robertvansteen robertvansteen deleted the patch-1 branch April 11, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants