can't load ssh key with extra spaces #2116
Description
phpseclib cannot load an authorized_keys-formatted public key with extra spaces:
<?php
ini_set("display_errors", 0);
require "./vendor/autoload.php";
echo "loading normal key...\n";
\phpseclib3\Crypt\PublicKeyLoader::load('ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIPbF9S6UiJErdX2OK9TCTn+CODCLTvBur2uAFyHluYLf foo');
echo "loading key with 2 spaces...\n";
\phpseclib3\Crypt\PublicKeyLoader::load('ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIPbF9S6UiJErdX2OK9TCTn+CODCLTvBur2uAFyHluYLf bar');loading normal key...
loading key with 2 spaces...
PHP Fatal error: Uncaught phpseclib3\Exception\NoKeyLoadedException: Unable to read key in /.../vendor/phpseclib/phpseclib/phpseclib/Crypt/PublicKeyLoader.php:64
Stack trace:
#0 /.../test.php(7): phpseclib3\Crypt\PublicKeyLoader::load(false)
#1 {main}
thrown in /.../vendor/phpseclib/phpseclib/phpseclib/Crypt/PublicKeyLoader.php on line 64This is due to the behavior of explode:
phpseclib/phpseclib/Crypt/Common/Formats/Keys/OpenSSH.php
Lines 122 to 141 in 574622e
php > var_dump(explode(" ", "hello world"));
array(2) {
[0]=>
string(5) "hello"
[1]=>
string(5) "world"
}
php > var_dump(explode(" ", "hello world"));
array(3) {
[0]=>
string(5) "hello"
[1]=>
string(0) ""
[2]=>
string(5) "world"
}