Fix endpoint port config in an umbrella application.#6549
Merged
SteffenDE merged 2 commits intophoenixframework:mainfrom Dec 8, 2025
Merged
Fix endpoint port config in an umbrella application.#6549SteffenDE merged 2 commits intophoenixframework:mainfrom
SteffenDE merged 2 commits intophoenixframework:mainfrom
Conversation
Contributor
|
🙌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: This PR fixes endpoint port configuration in
runtime.exsin a newly generated umbrella application. This is a regression introduced in Phoenix 1.8.2.I have noticed that with upgrade to Phoenix 1.8.2 port configuration has been moved to
runtime.exsand new lines have been added (#6449). I checked what's changed for an umbrella application (on phoenixdiff) and these are the lines that are added:while everywhere else, even in the very same file,
SampleAppWeb.Endpointis configured onsample_app_web, notsample_app.Steps to reproduce:
Observe the output.
Actual:
As we see, the custom port is not obeyed, and the endpoint URL is missing the port altogether.
Expected: