Skip to content

ci: downgrade hashbrown rather than limiting indexmap#714

Merged
XVilka merged 1 commit intopetgraph:masterfrom
cuviper:ci-msrv
Jan 4, 2025
Merged

ci: downgrade hashbrown rather than limiting indexmap#714
XVilka merged 1 commit intopetgraph:masterfrom
cuviper:ci-msrv

Conversation

@cuviper
Copy link
Copy Markdown
Contributor

@cuviper cuviper commented Jan 1, 2025

Pinning indexmap = "~2.5.0" for MSRV prevents users with more current compilers from using the latest petgraph and indexmap together, even though they would otherwise work fine. Instead, dependencies can just be downgraded as needed for CI testing, and users who need the older compiler support can also manage this in their own lock files.

Copy link
Copy Markdown
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@cuviper
Copy link
Copy Markdown
Contributor Author

cuviper commented Jan 5, 2025

Thanks for merging! Is there any plan for a point release so this can reach crates.io?

@XVilka
Copy link
Copy Markdown
Member

XVilka commented Jan 5, 2025

@cuviper yes, we could. But I am afk for a couple weeks. @indietyp or @ABorgna could probably help with this meanwhile.

@indietyp
Copy link
Copy Markdown
Member

indietyp commented Jan 5, 2025

Sure I can create a release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants