Add UnionFind::new_set#684
Merged
ABorgna merged 3 commits intopetgraph:masterfrom Feb 1, 2025
Merged
Conversation
Contributor
Author
|
it's been a while and there have been multiple releases since I made this PR...can it be merged or do I need to make some changes? I have a crate that I want to publish a new version of eventually where one of the things it has been waiting on is this being merged and published to crates.io |
This was referenced Apr 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
UnionFind::new_setto add a new set to an existingUnionFind, which is helpful when you want to incrementally use theUnionFindalgorithm and don't know how many elements you have ahead of time.Fixes: #683
Also adds additional utility methods since
UnionFinddoesn't have fixed length anymore:UnionFind::new_empty()-- equivalent toVec::new()for when you need aconstemptyUnionFind.UnionFind::is_empty()/UnionFind::len()-- returns the number of elements, likeVec::is_empty()/Vec::len()impl Default for UnionFind-- makes an emptyUnionFindI also switched
self.parent.len()calls to useself.len()since that's more canonical.I also added a test checking that
UnionFind::new_set()works correctly.