Merged
Conversation
ascjones
reviewed
Apr 24, 2023
ascjones
reviewed
Apr 25, 2023
Contributor
ascjones
left a comment
There was a problem hiding this comment.
Please add a line here
scale-info/.github/workflows/rust.yml
Line 45 in ce21de5
cargo check --no-default-features --features schema. At the moment that fails for me.
SkymanOne
commented
Apr 25, 2023
ascjones
approved these changes
Apr 25, 2023
Contributor
ascjones
left a comment
There was a problem hiding this comment.
LGTM!
Should be good to be a minor (non-breaking) release 👍
xermicus
approved these changes
Apr 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for schema generation required for ink! metadata verification. All types are now derive
schemars::JsonSchemaunder an optional feature flagschema