Drop rails 6.1/7.0 and ruby 3.0/3.1 support#1514
Merged
Conversation
053fc81 to
0c3c1f5
Compare
5604518 to
432af25
Compare
6 tasks
432af25 to
cdafc3f
Compare
cdafc3f to
123fb20
Compare
cfbc273 to
be77bf9
Compare
aa09b89 to
ec22c85
Compare
fatkodima
reviewed
Apr 4, 2025
Contributor
fatkodima
left a comment
There was a problem hiding this comment.
Made suggestions, other changes look good to me.
Member
|
@modosc, perhaps you should update https://github.com/paper-trail-gem/paper_trail/blob/master/README.md#1a-compatibility section. |
Artinens
pushed a commit
to rrebellion/paper_trail
that referenced
this pull request
Apr 14, 2026
* Drop rails 6.1/7.0 and ruby 3.0/3.1 support * upgrade rubocop-rspec + rspec-rails * disable RSpec/IndexedLet * autofix RSpec/IndexedLet * auto-fix Style/ArrayIntersect * autofix RSpec/ReceiveMessages * autofix RSpec/MetadataStyle * revert changes from bad rebase * revert .rubocop_todo.yml changes * empty line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: this depends on #1515this fixes #1513
this pr removes support for:
all of which are will be EOL'd by 2025-04-01.
the only significant change to the library code was the removal of
PaperTrail.active_record_gte_7_0?.it also upgrades
rspec-railsandrubocop-rspecto their most recent versions (both of these were previously blocked by rails 6.1 support). i ran autofixes and updated the.rubocop.ymlfile - each of these were done in a separate change so they should be easily undoable.Check the following boxes:
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.