Add more tests on Enum rendering#3053
Merged
Rowlando13 merged 1 commit intopallets:mainfrom Sep 11, 2025
kdeldycke:check-help-enum-rendering
Merged
Add more tests on Enum rendering#3053Rowlando13 merged 1 commit intopallets:mainfrom kdeldycke:check-help-enum-rendering
Enum rendering#3053Rowlando13 merged 1 commit intopallets:mainfrom
kdeldycke:check-help-enum-rendering
Conversation
Collaborator
Author
|
Thanks @Rowlando13 for the merge! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just some more unit-tests to demonstrate that Click use
Enums names instead of their values.These tests particularly highlight
Enum's whose keys mismatch their values. And add checks on the error messages proposing the accepted values for an option when a random one is provided by the user.Refs:
ChoiceprefersEnum.nameeven forStrEnumwhere it should use the value #2911click.Choiceprompt withStrEnumdisplays enum values but requires enum names #3028