Replace bash shell completion version error with warning#2576
Merged
davidism merged 1 commit intopallets:8.1.xfrom Aug 17, 2023
Merged
Replace bash shell completion version error with warning#2576davidism merged 1 commit intopallets:8.1.xfrom
davidism merged 1 commit intopallets:8.1.xfrom
Conversation
This was referenced Jul 29, 2023
Contributor
Author
|
#2581 should be merged first before this PR is merged. |
ce83716 to
d9db70c
Compare
Contributor
Author
|
It might be worth removing the warning when Bash is not on the system at all, so the behavior is more in line with Zsh and Fish. |
Member
|
I'm not planning to change it more. This is geared towards people using it directly, not towards other build systems. |
Contributor
Author
|
Makes sense. Thank you for your review and your work! I appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces instances of
raise RuntimeError(...)withecho(..., err=True)in_check_version().Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.