Skip to content

Fix swiftlint error that is unable to find lintable swift files#4427

Merged
echoix merged 1 commit intooxsecurity:mainfrom
Noraldeno:fixes/swiftlint-path
Dec 25, 2024
Merged

Fix swiftlint error that is unable to find lintable swift files#4427
echoix merged 1 commit intooxsecurity:mainfrom
Noraldeno:fixes/swiftlint-path

Conversation

@Noraldeno
Copy link
Copy Markdown
Contributor

@Noraldeno Noraldeno commented Dec 24, 2024 •
edited
Loading

Fixes #440

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@Noraldeno Noraldeno force-pushed the fixes/swiftlint-path branch from 0cd5cab to 6b2a6d7 Compare December 24, 2024 06:06
@echoix
Copy link
Copy Markdown
Collaborator

echoix commented Dec 24, 2024

Great work!
@nvuillam Do you want to take a look? The test cases pass, but not the Megalinter part.

@Noraldeno
Copy link
Copy Markdown
Contributor Author

Noraldeno commented Dec 24, 2024

@echoix Thx! Happy to help!

Looks like the linting error is the spell check. How do you usually handle spelling errors like this?

CHANGELOG.md:24:104    - Unknown word (lintable)   -- linter is unable to find lintable files. Fixes [#440]
	 Suggestions: [linable, liftable, lineable, linkable, listable]

@echoix
Copy link
Copy Markdown
Collaborator

echoix commented Dec 24, 2024

@echoix Thx! Happy to help!

Looks like the linting error is the spell check. How do you usually handle spelling errors like this?


CHANGELOG.md:24:104    - Unknown word (lintable)   -- linter is unable to find lintable files. Fixes [#440]

	 Suggestions: [linable, liftable, lineable, linkable, listable]

If it's not a typo, add them to the cspell exclusion (dict)

You can download the artifact and use the pre-populated changed file in report, removing the unnecessary changes if there's some typos to fix: https://github.com/oxsecurity/megalinter/actions/runs/12477772394

image

@Noraldeno
Fix swiftlint error that is unable to find lintable swift files
7891815 
- Update swiftlint documentation

- Update to use swiftlint's Docker image

- Add "lintable" to cspell exclusion

Fixes oxsecurity#440
@Noraldeno Noraldeno force-pushed the fixes/swiftlint-path branch from 6b2a6d7 to 7891815 Compare December 24, 2024 22:10
@Noraldeno
Copy link
Copy Markdown
Contributor Author

Noraldeno commented Dec 24, 2024

@echoix Thx! Happy to help!
Looks like the linting error is the spell check. How do you usually handle spelling errors like this?


CHANGELOG.md:24:104    - Unknown word (lintable)   -- linter is unable to find lintable files. Fixes [#440]

	 Suggestions: [linable, liftable, lineable, linkable, listable]

If it's not a typo, add them to the cspell exclusion (dict)

You can download the artifact and use the pre-populated changed file in report, removing the unnecessary changes if there's some typos to fix: https://github.com/oxsecurity/megalinter/actions/runs/12477772394

image

I added the word "lintable" to cspell exclusion

@echoix echoix merged commit 54384dd into oxsecurity:main Dec 25, 2024
@echoix
Copy link
Copy Markdown
Collaborator

echoix commented Dec 25, 2024

Should #1757 be closed now?

@Noraldeno Noraldeno deleted the fixes/swiftlint-path branch December 25, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@echoix echoix echoix approved these changes

@nvuillam nvuillam Awaiting requested review from nvuillam nvuillam is a code owner

@bdovaz bdovaz Awaiting requested review from bdovaz bdovaz is a code owner

@Kurt-von-Laven Kurt-von-Laven Awaiting requested review from Kurt-von-Laven Kurt-von-Laven is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linting swift code does not work. Error: No lintable files found at paths: '/tmp/lint'

2 participants

@Noraldeno @echoix