Skip to content

added kubescape as a linter to megalinter/descriptors/kubernetes.meg…#2531

Merged
nvuillam merged 15 commits intooxsecurity:mainfrom
muandane:feat/kubescape
May 13, 2023
Merged

added kubescape as a linter to megalinter/descriptors/kubernetes.meg…#2531
nvuillam merged 15 commits intooxsecurity:mainfrom
muandane:feat/kubescape

Conversation

@muandane
Copy link
Copy Markdown
Contributor

@muandane muandane commented Apr 5, 2023

kubernetes-linter-descriptor.yml

Feature: Kubescape security analysis as a kubernetes linter

Proposed Changes

  1. Install kubescape to do security checks on kubernetes manifests and helm charts
  2. Add Kubescape to Ci_light if posssible
  3. For now i configured it to run only the DevOps framework but if people are willing other frameworks could be added.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@muandane muandane requested a review from nvuillam as a code owner April 5, 2023 16:42
@nvuillam
Copy link
Copy Markdown
Member

nvuillam commented Apr 6, 2023

@muandane this PR looks great, many thanks for submitting it :)

To add an embedded linter, you need additional actions and file, that you can see in the following documentation

https://megalinter.io/latest/contributing/#add-a-new-linter

Don't hesitate to ask if you need support, thanks again :)

@muandane
Copy link
Copy Markdown
Contributor Author

muandane commented Apr 6, 2023 •
edited
Loading

@nvuillam i'm working on it and encountered an issue with documentation generation, but i couldn't find the doc URL in Megalinter Descriptor Schema or is it simply meant to be described by these two ["linter_repo:", "linter_url:"]

Edit:

  • i checked the py file that generates the markdown files, i think added the right definition but still the doc for kubescape isnt generated automatically with ./build.sh (since it's explicitly written DO NOT GENERATE THE DOC MANUALLY).
  • Unless this counts to the generated documentation mentioned in the contribution guide Standalone linters updated md file

@muandane muandane force-pushed the feat/kubescape branch 2 times, most recently from 4588490 to 4b2c7f8 Compare April 6, 2023 11:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label May 7, 2023
@bdovaz
Copy link
Copy Markdown
Collaborator

bdovaz commented May 7, 2023

@muandane are you still working on this?

@nvuillam nvuillam added nostale This issue or pull request is not stale, keep it open and removed O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity labels May 7, 2023
@nvuillam
Copy link
Copy Markdown
Member

nvuillam commented May 13, 2023

@bdovaz yes :)

nvuillam
nvuillam approved these changes May 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, many thanks for your contribution @muandane :)

cc @EtienneDeneuve

@nvuillam nvuillam merged commit 5ff5f1e into oxsecurity:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvuillam nvuillam nvuillam approved these changes

Assignees

No one assigned

Labels

nostale This issue or pull request is not stale, keep it open

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muandane @nvuillam @bdovaz