Skip to content

fix(lint): suppress unparam on toStaticValue#834

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/03-25-fix_lint_suppress_unparam_on_tostaticvalue
Mar 27, 2026
Merged

fix(lint): suppress unparam on toStaticValue#834
graphite-app[bot] merged 1 commit into
mainfrom
c/03-25-fix_lint_suppress_unparam_on_tostaticvalue

Conversation

@camc314

@camc314 camc314 commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

see #833 for reasoning - we may start using this in future.

In the mean time it makes sense to keep it to align with the upstream impl

@camc314 Graphite App

camc314 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add the label 0-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 self-assigned this Mar 25, 2026
@camc314 camc314 marked this pull request as ready for review March 25, 2026 20:39
Copilot AI review requested due to automatic review settings March 25, 2026 20:39
Copilot AI reviewed Mar 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR suppresses unparam linting on toStaticValue in the no-unnecessary-condition rule to keep the function signature aligned with upstream and preserve the (currently unused) return value for potential future checks (per #833).

Changes:

  • Add //nolint:unparam to toStaticValue with an explanatory comment to silence the “unused result” lint finding.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 Graphite App

camc314 commented Mar 27, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

@camc314
fix(lint): suppress unparam on toStaticValue (#834)
c140508 
see #833 for reasoning - we may start using this in future.

In the mean time it makes sense to keep it to align with the upstream impl
@graphite-app graphite-app Bot force-pushed the c/03-25-fix_lint_suppress_unparam_on_tostaticvalue branch from dcaf25c to c140508 Compare March 27, 2026 11:13
@graphite-app graphite-app Bot merged commit c140508 into main Mar 27, 2026
8 checks passed
@graphite-app graphite-app Bot deleted the c/03-25-fix_lint_suppress_unparam_on_tostaticvalue branch March 27, 2026 11:20
@graphite-app graphite-app Bot removed the 0-merge label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314