chore: update typescript-go to latest upstream#814
Merged
graphite-app[bot] merged 1 commit intoMar 20, 2026
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
c8e2536 to
039e588
Compare
camc314
commented
Mar 20, 2026
There was a problem hiding this comment.
Pull request overview
Updates the typescript-go submodule to a newer upstream commit and brings local shims/patches/snapshots back in sync with upstream API and diagnostic text changes.
Changes:
- Bump
typescript-gosubmodule revision. - Update Go shims (newly exposed symbols/aliases, signature changes, and struct layout sync).
- Refresh patchset metadata/content and update test snapshots to match new diagnostics.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| typescript-go | Updates the submodule commit pointer to the new upstream revision. |
| shim/tsoptions/shim.go | Exposes additional tsoptions conversion API and TSConfig type alias via shim. |
| shim/lsp/lsproto/shim.go | Adjusts shim function signature to match upstream range comparison API. |
| shim/checker/shim.go | Syncs checker shim struct/layout with upstream (new fields, new scanner dependency). |
| shim/ast/shim.go | Syncs exported AST constants with upstream (remove/add constants). |
| patches/0001-Parallel-readDirectory-visitor.patch | Updates patch metadata to reflect new patch series size and upstream commit ids. |
| patches/0002-Adapt-project-service-for-single-run-mode.patch | Updates patch metadata and upstream commit ids. |
| patches/0003-patch-expose-more-functions-via-the-shim-with-type-f.patch | Rebases/adjusts large project-related patch content to match upstream file changes. |
| patches/0004-fix-early-return-from-invalid-tsconfig-for-better-er.patch | Updates patch metadata and upstream commit ids. |
| patches/0005-fix-collections-avoid-internal-json-import-in-ordere.patch | Updates patch metadata and upstream commit ids. |
| patches/0006-perf-vfs-cache-ReadFile-results-in-cachedvfs.patch | Updates patch metadata and upstream commit ids. |
| patches/0007-fix-crash-on-JS-await-property-lookup.patch | Updates patch metadata and upstream commit ids. |
| internal/rule_tester/snapshots/no-unsafe-type-assertion.snap | Updates expected diagnostic message text to match upstream. |
| internal/rule_tester/snapshots/no-unsafe-assignment.snap | Updates expected diagnostic message text to match upstream. |
| internal/rule_tester/snapshots/no-unsafe-argument.snap | Updates expected diagnostic message text to match upstream. |
| e2e/snapshots/snapshot.test.ts.snap | Updates E2E snapshot diagnostic message text to match upstream. |
Comments suppressed due to low confidence (1)
patches/0003-patch-expose-more-functions-via-the-shim-with-type-f.patch:1
- In the patched
FileExistslogic, returningfalsewhenval == nilcan create a false negative if the path exists on disk but the cache entry is currently empty (e.g., after an eviction/partial-population scenario). Instead of returningfalseimmediately, the safer behavior is to fall back to a reload/check (e.g.,s.reloadEntryIfNeeded(entry) != nil) or delegate tos.fs.FileExists(fileName)soFileExistsremains correct even when cache entries are nil.
From 5e978188521b9ff108e5d41d384b854cb71b4a1a Mon Sep 17 00:00:00 2001
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a48b5c4 to
f57a392
Compare
Contributor
Author
Merge activity
|
f57a392 to
30f6606
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.