fix(no-base-to-string): check base types for ignoredTypeNames#796
Merged
camc314 merged 2 commits intooxc-project:mainfrom Mar 16, 2026
Merged
Conversation
The rule was only checking the type's own name against ignoredTypeNames,
missing classes that extend ignored types (e.g., `class Foo extends Error {}`).
Add `matchesTypeOrBaseType` to recursively walk the class hierarchy via
`getBaseTypes`, matching the upstream typescript-eslint implementation in
`baseTypeUtils.ts`. Handle TypeReference types by dereferencing through
`.Target()` before checking ClassOrInterface flags to avoid panics on
array/tuple reference types.
Closes oxc-project#749
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #749
The rule was only checking the type's own name against
ignoredTypeNames, so classes that extend an ignored type (e.g.,class Foo extends Error {}) were incorrectly flagged as violations.matchesTypeOrBaseTypeto recursively walk the class hierarchy viagetBaseTypes, matching the upstream typescript-eslint implementation inbaseTypeUtils.tsTypeReferencetypes by dereferencing through.Target()before checkingClassOrInterfaceflags, to avoid panics on array/tuple reference typesTest plan
class Foo extends Error {}(non-generic)class Foo<T> extends Error {}(generic)