fix(restrict-plus-operands): report actual type instead of always reporting RegExp#786
Merged
camc314 merged 3 commits intooxc-project:mainfrom Mar 10, 2026
Merged
Conversation
…orting RegExp When an invalid object-like operand (e.g. Date, Array, plain object) was used in a '+' operation, the error message always reported the type as 'RegExp' regardless of the actual type. This was because `checkInvalidPlusOperand` unconditionally returned `globalRegexpType` for any invalid object type. Now the function returns `baseTypeString` (the actual type) instead, so `'' + new Date()` correctly reports `Date` in the diagnostic. Ref oxc-project#518
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkInvalidPlusOperandto return the actual type string (baseTypeString) instead of always returningglobalRegexpTypefor any invalid object-like operand.Datetype operands ('' + new Date(),d + '',new Date() + new Date()).CLAUDE.mdsymlink toAGENTS.md.Ref #518 (fixes the first part: error message reporting
RegExpinstead of the actual type)Test plan
go test ./internal/rules/restrict_plus_operands/...passesgo test ./internal/...passesDate,never[],{},Valued,A) instead ofRegExp