chore: update typescript-go submodule#785
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
Updates the vendored typescript-go dependency and regenerates the Go shims to match upstream API changes, including new UTF-16-aware position helpers and moved function-flag helpers.
Changes:
- Bump
github.com/microsoft/typescript-goand related Go dependencies across the root module and shim submodules. - Regenerate shims to reflect upstream API shifts (scanner position APIs, function flags, new exported helpers/constants).
- Update rule tester output rendering and snapshot fixtures to use UTF-16-based column calculations.
Reviewed changes
Copilot reviewed 40 out of 55 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shim/vfs/osvfs/go.sum | Update dependency sums for the osvfs shim module. |
| shim/vfs/osvfs/go.mod | Bump Go version and typescript-go + indirect deps for osvfs shim module. |
| shim/vfs/go.sum | Update dependency sums for vfs shim module. |
| shim/vfs/go.mod | Bump Go version and typescript-go + indirect deps for vfs shim module. |
| shim/vfs/cachedvfs/go.sum | Update dependency sums for cachedvfs shim module. |
| shim/vfs/cachedvfs/go.mod | Bump Go version and typescript-go + indirect deps for cachedvfs shim module. |
| shim/tspath/go.sum | Update dependency sums for tspath shim module. |
| shim/tspath/go.mod | Bump Go version and typescript-go for tspath shim module. |
| shim/tsoptions/go.sum | Update dependency sums (incl. x/sys/x/text) for tsoptions shim module. |
| shim/tsoptions/go.mod | Bump Go version and typescript-go + indirect deps for tsoptions shim module. |
| shim/scanner/shim.go | Regenerate scanner shim: replace ambiguous “Character” APIs with ByteOffset/UTF16-specific variants. |
| shim/scanner/go.sum | Update dependency sums for scanner shim module. |
| shim/scanner/go.mod | Bump Go version and typescript-go + indirect deps for scanner shim module. |
| shim/project/shim.go | Expose new project update reason constant from upstream. |
| shim/project/go.sum | Update dependency sums for project shim module. |
| shim/project/go.mod | Bump Go version and typescript-go + indirect deps for project shim module. |
| shim/parser/go.sum | Update dependency sums for parser shim module. |
| shim/parser/go.mod | Bump Go version and typescript-go + indirect deps for parser shim module. |
| shim/lsp/lsproto/go.sum | Update dependency sums for lsproto shim module. |
| shim/lsp/lsproto/go.mod | Bump Go version and typescript-go + indirect deps for lsproto shim module. |
| shim/core/shim.go | Regenerate core shim: rename line/column helper and expose UTF16 helpers/types. |
| shim/core/go.sum | Update dependency sums for core shim module. |
| shim/core/go.mod | Bump Go version and typescript-go + indirect deps for core shim module. |
| shim/compiler/go.sum | Update dependency sums for compiler shim module. |
| shim/compiler/go.mod | Bump Go version and typescript-go + indirect deps for compiler shim module. |
| shim/checker/shim.go | Regenerate checker shim: remove old function-flag exports and adjust internal layout/types. |
| shim/checker/go.sum | Update dependency sums for checker shim module. |
| shim/checker/go.mod | Bump Go version and typescript-go + indirect deps for checker shim module. |
| shim/checker/extra-shim.json | Remove getFunctionFlags from checker extra shim config (moved to ast). |
| shim/bundled/go.sum | Update dependency sums for bundled shim module. |
| shim/bundled/go.mod | Bump Go version and typescript-go + indirect deps for bundled shim module. |
| shim/ast/shim.go | Regenerate ast shim: add GetFunctionFlags, FunctionFlags, and additional helpers/types. |
| shim/ast/go.sum | Update dependency sums for ast shim module. |
| shim/ast/go.mod | Bump Go version and typescript-go + indirect deps for ast shim module. |
| patches/0007-perf-cache-readfile-in-cachedvfs.patch | Refresh patch metadata after upstream commit update / patch series count change. |
| patches/0006-fix-collections-ordered-map-public-json.patch | Refresh patch metadata after upstream commit update / patch series count change. |
| patches/0005-feat-checker-add-IndexInfo-accessor-methods-for-shim.patch | Remove obsolete patch from the maintained patch set. |
| patches/0004-fix-early-return-from-invalid-tsconfig-for-better-er.patch | Refresh patch metadata after upstream commit update / patch series count change. |
| patches/0003-patch-expose-more-functions-via-the-shim-with-type-f.patch | Refresh patch metadata after upstream commit update / patch series count change. |
| patches/0002-Adapt-project-service-for-single-run-mode.patch | Refresh patch metadata after upstream commit update / patch series count change. |
| patches/0001-Parallel-readDirectory-visitor.patch | Refresh patch metadata after upstream commit update / patch series count change. |
| internal/utils/overlay_vfs.go | Update OverlayVFS WriteFile signature to match updated vfs.FS. |
| internal/rules/switch_exhaustiveness_check/switch_exhaustiveness_check.go | Switch indentation computation to UTF-16 column API. |
| internal/rules/strict_void_return/strict_void_return.go | Use ast.GetFunctionFlags / ast.FunctionFlags* instead of checker equivalents. |
| internal/rules/strict_boolean_expressions/strict_boolean_expressions.go | Use ast.GetFunctionFlags / ast.FunctionFlagsAsync. |
| internal/rules/require_await/require_await.go | Migrate function flag storage and checks to ast.FunctionFlags. |
| internal/rules/consistent_return/consistent_return.go | Use ast.GetFunctionFlags and ast.FunctionFlagsAsync. |
| internal/rule_tester/snapshot.go | Render diagnostics using UTF-16 columns and cast offsets appropriately. |
| internal/rule_tester/rule_tester.go | Validate expected diagnostics using UTF-16 columns and cast offsets appropriately. |
| internal/rule_tester/snapshots/prefer-string-starts-ends-with.snap | Update expected ranges/underlines due to UTF-16 column accounting. |
| internal/rule_tester/snapshots/no-unnecessary-template-expression.snap | Update expected ranges/underlines due to UTF-16 column accounting. |
| internal/rule_tester/snapshots/consistent-type-exports.snap | Update expected ranges/underlines due to UTF-16 column accounting. |
| go.sum | Update root dependency sums for updated typescript-go and Go x/* deps. |
| go.mod | Update root module requirements (typescript-go + json pseudo-version + x/mod bump). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Merge activity
|
8c82e72 to
4d00f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.