fix(return-await): guard concise arrow body path with hasAsync check#751
Merged
camc314 merged 2 commits intooxc-project:mainfrom Feb 26, 2026
Merged
Conversation
Non-async arrow functions with a concise body (e.g. `const f = () =>
Promise.resolve(1)`) were incorrectly flagged in `always` mode because
`testEachPossiblyReturnedNode` was called without checking `scope.hasAsync`.
The `KindReturnStatement` handler already had this guard; add the same
guard to the `KindArrowFunction` exit handler.
Fixes: non-async concise arrows producing TS1308 ('await' expression
only allowed in async functions) when the unsafe fixer is applied.
connorshea
reviewed
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const f = (): Promise<number> => Promise.resolve(1)) were incorrectly flagged inalways,in-try-catch, anderror-handling-correctness-onlymodesKindArrowFunctionexit handler calledtestEachPossiblyReturnedNodeon the concise body without checkingscope.hasAsync, bypassing the guard that already exists on theKindReturnStatementhandler&& scope != nil && scope.hasAsyncto the concise-body branch, making it consistent with the block-body pathTest plan
Promise, one per affected mode (always,in-try-catch,error-handling-correctness-only)go test ./internal/rules/return_await/...passes🤖 Generated with Claude Code