Skip to content

feat: add suggestions for switch-exhaustiveness-check#720

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-20-feat_add_suggestions_for_switch-exhaustiveness-check_
Feb 21, 2026
Merged

feat: add suggestions for switch-exhaustiveness-check#720
graphite-app[bot] merged 1 commit intomainfrom
02-20-feat_add_suggestions_for_switch-exhaustiveness-check_

Conversation

@camchenry
Copy link
Copy Markdown
Member

@camchenry camchenry commented Feb 21, 2026

NOTE: AI was used to help implement much of this. I recommend reviewing this PR with whitespace changes hidden, as most of the changes revolve around simply extracting the helper closures to the top-level, since they don't need to change between rule runs.

The ported code was strongly based on the upstream typescript-eslint implementation, and I believe we have parity with all of the test cases here.

Copy link
Copy Markdown
Member Author

camchenry commented Feb 21, 2026


How to use the Graphite Merge Queue

Add the label 0-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry changed the base branch from 02-20-feat_switch-exhaustiveness-check_report_all_missing_cases to graphite-base/720 February 21, 2026 04:07
@camchenry camchenry force-pushed the 02-20-feat_add_suggestions_for_switch-exhaustiveness-check_ branch from 5bb397b to 88805a4 Compare February 21, 2026 04:09
@camchenry camchenry changed the base branch from graphite-base/720 to 02-20-feat_switch-exhaustiveness-check_report_all_missing_cases February 21, 2026 04:09
@camchenry camchenry marked this pull request as ready for review February 21, 2026 04:16
@camc314 camc314 self-assigned this Feb 21, 2026
Copy link
Copy Markdown
Contributor

camc314 commented Feb 21, 2026

Merge activity

- Part of #668

NOTE: AI was used to help implement much of this. I recommend reviewing this PR with whitespace changes hidden, as most of the changes revolve around simply extracting the helper closures to the top-level, since they don't need to change between rule runs.

The ported code was strongly based on the upstream typescript-eslint implementation, and I believe we have parity with all of the test cases here.
@graphite-app graphite-app bot force-pushed the 02-20-feat_switch-exhaustiveness-check_report_all_missing_cases branch from ef16c42 to 9798c64 Compare February 21, 2026 11:52
@graphite-app graphite-app bot force-pushed the 02-20-feat_add_suggestions_for_switch-exhaustiveness-check_ branch from 88805a4 to ef099e8 Compare February 21, 2026 11:52
Base automatically changed from 02-20-feat_switch-exhaustiveness-check_report_all_missing_cases to main February 21, 2026 11:59
@graphite-app graphite-app bot removed the 0-merge label Feb 21, 2026
@graphite-app graphite-app bot merged commit ef099e8 into main Feb 21, 2026
8 checks passed
@graphite-app graphite-app bot deleted the 02-20-feat_add_suggestions_for_switch-exhaustiveness-check_ branch February 21, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants