perf: avoid temporary Vec in ConcatSourceMapBuilder::add_sourcemap#290
Merged
perf: avoid temporary Vec in ConcatSourceMapBuilder::add_sourcemap#290
Vec in ConcatSourceMapBuilder::add_sourcemap#290Conversation
Merging this PR will degrade performance by 3.17%
Performance Changes
Comparing 
Footnotes
|
Push tokens directly into `self.tokens` with inline deduplication of the first token, instead of collecting into a temporary `Vec` and then copying with `extend_from_slice`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0ac781a to
d7054c8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self.tokenswith inline deduplication of the first token, instead of collecting into a temporaryVecand then copying withextend_from_slice.🤖 Generated with Claude Code