Skip to content

feat: omit sourcesContent if all of the values are null#287

Merged
Boshen merged 1 commit intomainfrom
feat/omit-sources-content-if-all-of-the-values-are-null
Mar 20, 2026
Merged

feat: omit sourcesContent if all of the values are null#287
Boshen merged 1 commit intomainfrom
feat/omit-sources-content-if-all-of-the-values-are-null

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

To reduce the sourcemap size.

Reading the spec, it is probably safe to remove any trailing null values in sourcesContent. But I didn't do so as some implementation may expect the length of sourcesContent and sources to be matched unless it's completely omitted.

@sapphi-red sapphi-red force-pushed the feat/omit-sources-content-if-all-of-the-values-are-null branch from b3dc710 to 8da5ce0 Compare March 20, 2026 11:33
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 20, 2026

Merging this PR will not alter performance

✅ 13 untouched benchmarks
⏩ 5 skipped benchmarks1


Comparing feat/omit-sources-content-if-all-of-the-values-are-null (8da5ce0) with main (7d35c3f)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen merged commit 59d8044 into main Mar 20, 2026
7 checks passed
@Boshen Boshen deleted the feat/omit-sources-content-if-all-of-the-values-are-null branch March 20, 2026 12:16
@Boshen Boshen mentioned this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants