Skip to content

fix: x_google_ignoreList encode format#165

Merged
Boshen merged 2 commits intomainfrom
09-24-fix_x_google_ignorelist_encode_format
Sep 24, 2025
Merged

fix: x_google_ignoreList encode format#165
Boshen merged 2 commits intomainfrom
09-24-fix_x_google_ignorelist_encode_format

Conversation

@Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Sep 24, 2025 •
edited
Loading

@Brooooooklyn Graphite App
Copy link
Member Author

Brooooooklyn commented Sep 24, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI reviewed Sep 24, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the encoding format for the x_google_ignoreList field in source maps by properly formatting numeric values as JSON integers instead of escaped strings.

  • Updates the encoding logic to use write! macro for direct formatting instead of string conversion
  • Removes unnecessary string constraint on the generic push_list method
  • Adjusts memory allocation estimation for the ignore list items

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #165 will degrade performances by 2.25%

Comparing 09-24-fix_x_google_ignorelist_encode_format (a698472) with main (a60144b)

Summary

❌ 1 regression
✅ 4 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ generate_lookup_table 1.3 µs 1.3 µs -2.25%

@Boshen Boshen merged commit a7db094 into main Sep 24, 2025
7 checks passed
@Boshen Boshen deleted the 09-24-fix_x_google_ignorelist_encode_format branch September 24, 2025 07:03
@Boshen Boshen mentioned this pull request Sep 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Boshen Boshen Awaiting requested review from Boshen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Brooooooklyn @Boshen