Skip to content

fix: resolve node_modules/package/dir/foo.js if node_modules/package/dir/foo/ exists#896

Merged
Boshen merged 1 commit into
mainfrom
12-02-fix_resolve_node_modules_package_foo.js_if_node_modules_package_foo__exists
Dec 2, 2025
Merged

fix: resolve node_modules/package/dir/foo.js if node_modules/package/dir/foo/ exists#896
Boshen merged 1 commit into
mainfrom
12-02-fix_resolve_node_modules_package_foo.js_if_node_modules_package_foo__exists

Conversation

@Boshen

@Boshen Boshen commented Dec 2, 2025

Copy link
Copy Markdown
Member

fixes #893
closes #894

PR #839 incorrectly assumed the specifier is always a package name, but a specifier can be package/dir/foo where both node_modules/package/dir/foo.js and node_modules/package/dir/foo/ exists.

@Boshen
fix: resolve node_modules/package/dir/foo.js if `node_modules/packa…
8a75edd 
…ge/dir/foo/` exists

fixes #893
closes #894

PR #839 incorrectly assumed the specifier is always a package name,
but a specifier can be `package/dir/foo` where both `node_modules/package/dir/foo.js` and `node_modules/package/dir/foo/` exists.
@graphite-app

graphite-app Bot commented Dec 2, 2025

Copy link
Copy Markdown

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov

codecov Bot commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.39%. Comparing base (a1d806b) to head (8a75edd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   94.38%   94.39%           
=======================================
  Files          17       17           
  Lines        3243     3248    +5     
=======================================
+ Hits         3061     3066    +5     
  Misses        182      182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Dec 2, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #896 will improve performances by 3.17%

Comparing 12-02-fix_resolve_node_modules_package_foo.js_if_node_modules_package_foo__exists (8a75edd) with main (a1d806b)

Summary

⚡ 1 improvement
✅ 11 untouched
⏩ 5 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ resolver_memory[multi-thread] 483.7 µs 468.9 µs +3.17%

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Boshen Boshen merged commit 121152f into main Dec 2, 2025
18 checks passed
@Boshen Boshen deleted the 12-02-fix_resolve_node_modules_package_foo.js_if_node_modules_package_foo__exists branch December 2, 2025 11:40
@Boshen Boshen mentioned this pull request Dec 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package subpath resolution fails when package.json has no exports field

1 participant

@Boshen