Skip to content

fix(linter): rules-of-hooks fix false positive with default export#7570

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export
Dec 2, 2024
Merged

fix(linter): rules-of-hooks fix false positive with default export#7570
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Dec 1, 2024

closes #7555

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Dec 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 1, 2024

@camc314 camc314 marked this pull request as ready for review December 1, 2024 18:28
@github-actions github-actions Bot added A-linter Area - Linter C-bug Category - Bug labels Dec 1, 2024
Comment thread crates/oxc_linter/src/rules/react/rules_of_hooks.rs
@camc314 camc314 force-pushed the c/12-01-chore_linter_update_rules_of_hooks_test_cases branch from 3d14861 to 0557f8c Compare December 1, 2024 18:31
@camc314 camc314 force-pushed the c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export branch from a5a1ef2 to 26014c6 Compare December 1, 2024 18:31
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #7570 will not alter performance

Comparing c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export (4e3044e) with main (e62153b)

Summary

✅ 30 untouched benchmarks

@camc314 camc314 force-pushed the c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export branch from 26014c6 to 261c279 Compare December 1, 2024 18:59
@camc314
Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 1, 2024

@Boshen i think we shuold promote this one to correctness after running in ecosystem CI.

@camc314 camc314 force-pushed the c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export branch from 261c279 to c53c69d Compare December 1, 2024 19:09
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 2, 2024
Copy link
Copy Markdown
Member

Boshen commented Dec 2, 2024

Merge activity

  • Dec 1, 10:08 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 10:09 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 1, 10:17 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/12-01-chore_linter_update_rules_of_hooks_test_cases branch from 0557f8c to cb1f8e6 Compare December 2, 2024 03:09
@Boshen Boshen force-pushed the c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export branch from c53c69d to 4e3044e Compare December 2, 2024 03:10
Base automatically changed from c/12-01-chore_linter_update_rules_of_hooks_test_cases to main December 2, 2024 03:14
@graphite-app graphite-app Bot merged commit 4e3044e into main Dec 2, 2024
@graphite-app graphite-app Bot deleted the c/12-01-fix_linter_rules-of-hooks_fix_false_positive_with_default_export branch December 2, 2024 03:17
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(linter): false positve "react-hooks/RulesOfHooks" with default export

2 participants