feat(linter): Implement eslint/no-object-constructor#7345
Merged
camc314 merged 8 commits intooxc-project:mainfrom Nov 23, 2024
Merged
feat(linter): Implement eslint/no-object-constructor#7345camc314 merged 8 commits intooxc-project:mainfrom
camc314 merged 8 commits intooxc-project:mainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #7345 will not alter performanceComparing Summary
|
no-yan
reviewed
Nov 19, 2024
Contributor
no-yan
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Since the team seem to be focusing on other tasks, I’ve added comments on smaller points to help keep things moving efficiently.
Co-authored-by: no-yan <63000297+no-yan@users.noreply.github.com>
camc314
approved these changes
Nov 23, 2024
Contributor
camc314
left a comment
There was a problem hiding this comment.
thank you! apologies for the delay reviewing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, again!
I added eslint rule eslint/no-object-constructor
https://eslint.org/docs/latest/rules/no-object-constructor
Notes
A test case for
new Object()has been commented out:This is due to the test configuration specifying
globals: { Object: "off" }.This approach follows the example set by the no_new_wrappers rule. Reference Code