fix(ast/estree): add TS fields to LabelIdentifier (#10295)

overlookmotel · overlookmotel · commit e42c040c8520 · 2025-04-07T14:34:54.000Z
Add missing fields to `LabelIdentifier` in TS AST. Part of #9705.
diff --git a/crates/oxc_ast/src/ast/js.rs b/crates/oxc_ast/src/ast/js.rs
@@ -279,7 +279,10 @@ pub struct BindingIdentifier<'a> {
 #[ast(visit)]
 #[derive(Debug, Clone)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree)]
-#[estree(rename = "Identifier")]
+#[estree(
+    rename = "Identifier",
+    add_fields(decorators = TsEmptyArray, optional = TsFalse, typeAnnotation = TsNull),
+)]
 pub struct LabelIdentifier<'a> {
     pub span: Span,
     #[estree(json_safe)]
diff --git a/crates/oxc_ast/src/generated/derive_estree.rs b/crates/oxc_ast/src/generated/derive_estree.rs
@@ -119,6 +119,9 @@ impl ESTree for LabelIdentifier<'_> {
         state.serialize_field("start", &self.span.start);
         state.serialize_field("end", &self.span.end);
         state.serialize_field("name", &JsonSafeString(self.name.as_str()));
+        state.serialize_ts_field("decorators", &crate::serialize::TsEmptyArray(self));
+        state.serialize_ts_field("optional", &crate::serialize::TsFalse(self));
+        state.serialize_ts_field("typeAnnotation", &crate::serialize::TsNull(self));
         state.end();
     }
 }
diff --git a/napi/parser/deserialize-ts.js b/napi/parser/deserialize-ts.js
@@ -92,6 +92,9 @@ function deserializeLabelIdentifier(pos) {
     start: deserializeU32(pos),
     end: deserializeU32(pos + 4),
     name: deserializeStr(pos + 8),
+    decorators: [],
+    optional: false,
+    typeAnnotation: null,
   };
 }
 
diff --git a/npm/oxc-types/types.d.ts b/npm/oxc-types/types.d.ts
@@ -78,6 +78,9 @@ export interface BindingIdentifier extends Span {
 export interface LabelIdentifier extends Span {
   type: 'Identifier';
   name: string;
+  decorators?: [];
+  optional?: false;
+  typeAnnotation?: null;
 }
 
 export interface ThisExpression extends Span {
diff --git a/tasks/coverage/snapshots/estree_typescript.snap b/tasks/coverage/snapshots/estree_typescript.snap

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,9 @@ impl ESTree for LabelIdentifier<'_> {`
`119`	`119`	`state.serialize_field("start", &self.span.start);`
`120`	`120`	`state.serialize_field("end", &self.span.end);`
`121`	`121`	`state.serialize_field("name", &JsonSafeString(self.name.as_str()));`
	`122`	`+ state.serialize_ts_field("decorators", &crate::serialize::TsEmptyArray(self));`
	`123`	`+ state.serialize_ts_field("optional", &crate::serialize::TsFalse(self));`
	`124`	`+ state.serialize_ts_field("typeAnnotation", &crate::serialize::TsNull(self));`
`122`	`125`	`state.end();`
`123`	`126`	`}`
`124`	`127`	`}`
Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,9 @@ function deserializeLabelIdentifier(pos) {`
`92`	`92`	`start: deserializeU32(pos),`
`93`	`93`	`end: deserializeU32(pos + 4),`
`94`	`94`	`name: deserializeStr(pos + 8),`
	`95`	`+ decorators: [],`
	`96`	`+ optional: false,`
	`97`	`+ typeAnnotation: null,`
`95`	`98`	`};`
`96`	`99`	`}`
`97`	`100`
Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,9 @@ export interface BindingIdentifier extends Span {`
`78`	`78`	`export interface LabelIdentifier extends Span {`
`79`	`79`	`type: 'Identifier';`
`80`	`80`	`name: string;`
	`81`	`+ decorators?: [];`
	`82`	`+ optional?: false;`
	`83`	`+ typeAnnotation?: null;`
`81`	`84`	`}`
`82`	`85`
`83`	`86`	`export interface ThisExpression extends Span {`