fix(linter): make require post message target origin a fixer a suggestion (#10754)

camc314 · camc314 · commit b38338a44a92 · 2025-05-01T13:14:18.000Z
from #10439 previously, the below fixer fixed the code ``` export function getPostMessage(port: MessagePort): <T>(message: T) => void { - return <T>(message: T) => port.postMessage(message); + return <T>(message: T) => port.postMessage(message, port.location.origin); } ``` which is unsafe since `MessagePort` does not have that type signature.
diff --git a/crates/oxc_linter/src/rules/unicorn/require_post_message_target_origin.rs b/crates/oxc_linter/src/rules/unicorn/require_post_message_target_origin.rs
@@ -41,7 +41,7 @@ declare_oxc_lint!(
     RequirePostMessageTargetOrigin,
     unicorn,
     suspicious,
-    fix
+    suggestion
 );
 
 impl Rule for RequirePostMessageTargetOrigin {
@@ -75,7 +75,7 @@ impl Rule for RequirePostMessageTargetOrigin {
             Span::new(arg.span().end, call_expr.span.end).source_text(ctx.source_text()).find(',');
         let offset = comma_idx.unwrap_or(0) as u32;
         let target_span = Span::new(arg.span().end + offset, call_expr.span.end);
-        ctx.diagnostic_with_fix(
+        ctx.diagnostic_with_suggestion(
             require_post_message_target_origin_diagnostic(target_span),
             |fixer| {
                 let last_token = Span::new(call_expr.span.end - 1, call_expr.span.end);
