fix(oxlint): current dir as arg (#9382)

BenShelton · web-flow · commit 9a0206693ad0 · 2025-04-24T11:45:55.000+08:00
closes #9023 When passing `.` as an arg it would result in a path like `{cwd}/.`, which when being used to resolve other paths obviously caused issues. This canonicalizes any path args before doing anything else. Adds test to verify this based on original issue. This also caused another snapshot to change for an invalid file extension, changing from `LintSucceeded` to `LintNoFilesFound`, which I believe is actually correct? If you only pass files that do not exist it would make more sense to return an error to me so I'm viewing this as a side effect fix.
diff --git a/apps/oxlint/fixtures/ignore_file_current_dir/.oxlintrc.json b/apps/oxlint/fixtures/ignore_file_current_dir/.oxlintrc.json
@@ -0,0 +1,10 @@
+{
+  "ignorePatterns": [
+    "foo.js",
+    "a/bar.js"
+  ],
+  "rules": {
+    "no-debugger": "deny"
+  }
+}
+
diff --git a/apps/oxlint/fixtures/ignore_file_current_dir/a/bar.js b/apps/oxlint/fixtures/ignore_file_current_dir/a/bar.js
@@ -0,0 +1,2 @@
+debugger
+console.log("Don't lint me!!")
diff --git a/apps/oxlint/fixtures/ignore_file_current_dir/foo.js b/apps/oxlint/fixtures/ignore_file_current_dir/foo.js
@@ -0,0 +1,2 @@
+debugger
+console.log("Don't lint me!!")
diff --git a/apps/oxlint/src/lint.rs b/apps/oxlint/src/lint.rs
@@ -122,8 +122,10 @@ impl Runner for LintRunner {
                 let (ignore, _err) = Gitignore::new(&ignore_options.ignore_path);
 
                 paths.retain_mut(|p| {
-                    // Append cwd to all paths
-                    let mut path = self.cwd.join(&p);
+                    // Try to prepend cwd to all paths
+                    let Ok(mut path) = absolute(self.cwd.join(&p)) else {
+                        return false;
+                    };
 
                     std::mem::swap(p, &mut path);
 
@@ -631,6 +633,16 @@ mod test {
         Tester::new().test_and_snapshot(args);
     }
 
+    #[test]
+    // https://github.com/oxc-project/oxc/issues/9023
+    fn ignore_file_current_dir() {
+        let args1 = &[];
+        let args2 = &["."];
+        Tester::new()
+            .with_cwd("fixtures/ignore_file_current_dir".into())
+            .test_and_snapshot_multiple(&[args1, args2]);
+    }
+
     #[test]
     fn filter_allow_all() {
         let args = &["-A", "all", "fixtures/linter"];
diff --git a/apps/oxlint/src/snapshots/fixtures__ignore_file_current_dir_ .@oxlint.snap b/apps/oxlint/src/snapshots/fixtures__ignore_file_current_dir_ .@oxlint.snap
@@ -0,0 +1,22 @@
+---
+source: apps/oxlint/src/tester.rs
+---
+########## 
+arguments: 
+working directory: fixtures/ignore_file_current_dir
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 0 files with 99 rules using 1 threads.
+----------
+CLI result: LintSucceeded
+----------
+
+########## 
+arguments: .
+working directory: fixtures/ignore_file_current_dir
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 0 files with 99 rules using 1 threads.
+----------
+CLI result: LintSucceeded
+----------

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+debugger`
	`2`	`+console.log("Don't lint me!!")`