fix(linter/exhaustive-deps): ignore empty strings passed to additionalHooks option (#14464)

holoflash · web-flow · commit 99656762bee4 · 2025-10-12T12:45:32.000+01:00
### Issue
Passing an empty string to **additionalHooks** in the
**react-hooks/exhaustive-deps** rule:
`"react-hooks/exhaustive-deps": ["error", { "additionalHooks": "" }],`
causes the linter to consider all functions to be additionalHooks.

### Behaviour in ESLint
Passing an empty string doesn't do anything.
Passing `"()"` causes the same problematic behaviour:
`"react-hooks/exhaustive-deps": ["warn", { additionalHooks: "()" }],`
The same is true for oxlint.

### Suggested fix
Check for empty string.
Since ESLint is able to take an empty string without breaking - so
should oxlint.
Ideally - handle the "()" case too, or leave it as is to match original
behaviour.

### How to test
Add:
`"react-hooks/exhaustive-deps": ["error", { "additionalHooks": "" }],`
to your .oxlintrc.json file
Lint the codebase.

Example:
```
function MyComponent(props) {
          const foo = bar.add();
    }
```

```
  ⚠ eslint-plugin-react-hooks(exhaustive-deps): React hook add requires an effect callback.
   ╭─[exhaustive_deps.tsx:2:23]
 1 │ function MyComponent(props) {
 2 │           const foo = bar.add();
   ·                       ─────────
 3 │         }
   ╰────
  help: Did you forget to pass a callback to the hook?

-------- rule config --------
[
  {
    "additionalHooks": ""
  }
]
```
diff --git a/crates/oxc_linter/src/rules/react/exhaustive_deps.rs b/crates/oxc_linter/src/rules/react/exhaustive_deps.rs
@@ -277,6 +277,7 @@ impl Rule for ExhaustiveDeps {
             .map(|config_json| ExhaustiveDepsConfig {
                 additional_hooks: config_json
                     .additional_hooks
+                    .filter(|pattern| !pattern.is_empty())
                     .and_then(|pattern| Regex::new(&pattern).ok()),
             })
             .unwrap_or_default();
@@ -4128,6 +4129,14 @@ fn test() {
         Some(serde_json::json!([{ "additionalHooks": "useSpecialEffect" }])),
     )];
 
+    let pass_additional_hooks_empty_string = vec![(
+        "function MyComponent(props) {
+          const foo = bar.add();
+        }
+        ",
+        Some(serde_json::json!([{ "additionalHooks": "" }])),
+    )];
+
     let fail_additional_hooks = vec![(
         "function MyComponent() {
           const [state, setState] = React.useState<number>(0);
@@ -4269,7 +4278,11 @@ fn test() {
     Tester::new(
         ExhaustiveDeps::NAME,
         ExhaustiveDeps::PLUGIN,
-        pass.iter().map(|&code| (code, None)).chain(pass_additional_hooks).collect::<Vec<_>>(),
+        pass.iter()
+            .map(|&code| (code, None))
+            .chain(pass_additional_hooks)
+            .chain(pass_additional_hooks_empty_string)
+            .collect::<Vec<_>>(),
         fail.iter().map(|&code| (code, None)).chain(fail_additional_hooks).collect::<Vec<_>>(),
     )
     .expect_fix(fix)
