perf(linter): refactor no-invalid-fetch-options to be more easily analyzed (#14458)

camchenry · camchenry · commit 78261d63c0df · 2025-10-09T05:39:12.000Z
Updating the code style here so that the linter codegen can more easily analyze this rule's node types.

+1% perf gain on the radix UI benchmark file.
diff --git a/crates/oxc_linter/src/generated/rule_runner_impls.rs b/crates/oxc_linter/src/generated/rule_runner_impls.rs
@@ -2416,7 +2416,8 @@ impl RuleRunner for crate::rules::unicorn::no_instanceof_builtins::NoInstanceofB
 }
 
 impl RuleRunner for crate::rules::unicorn::no_invalid_fetch_options::NoInvalidFetchOptions {
-    const NODE_TYPES: Option<&AstTypesBitset> = None;
+    const NODE_TYPES: Option<&AstTypesBitset> =
+        Some(&AstTypesBitset::from_types(&[AstType::CallExpression, AstType::NewExpression]));
 }
 
 impl RuleRunner
diff --git a/crates/oxc_linter/src/rules/unicorn/no_invalid_fetch_options.rs b/crates/oxc_linter/src/rules/unicorn/no_invalid_fetch_options.rs
@@ -59,29 +59,30 @@ declare_oxc_lint!(
 
 impl Rule for NoInvalidFetchOptions {
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
-        let arg = match node.kind() {
+        match node.kind() {
             AstKind::CallExpression(call_expr) => {
                 if !call_expr.callee.is_specific_id("fetch") || call_expr.arguments.len() < 2 {
                     return;
                 }
 
-                &call_expr.arguments[1]
+                if let Argument::ObjectExpression(expr) = &call_expr.arguments[1]
+                    && let Some((method_name, body_span)) = is_invalid_fetch_options(expr, ctx)
+                {
+                    ctx.diagnostic(no_invalid_fetch_options_diagnostic(body_span, &method_name));
+                }
             }
             AstKind::NewExpression(new_expr) => {
                 if !is_new_expression(new_expr, &["Request"], Some(2), None) {
                     return;
                 }
 
-                &new_expr.arguments[1]
+                if let Argument::ObjectExpression(expr) = &new_expr.arguments[1]
+                    && let Some((method_name, body_span)) = is_invalid_fetch_options(expr, ctx)
+                {
+                    ctx.diagnostic(no_invalid_fetch_options_diagnostic(body_span, &method_name));
+                }
             }
-            _ => return,
-        };
-
-        let Argument::ObjectExpression(expr) = arg else { return };
-        let result = is_invalid_fetch_options(expr, ctx);
-
-        if let Some((method_name, body_span)) = result {
-            ctx.diagnostic(no_invalid_fetch_options_diagnostic(body_span, &method_name));
+            _ => {}
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -2416,7 +2416,8 @@ impl RuleRunner for crate::rules::unicorn::no_instanceof_builtins::NoInstanceofB`
`2416`	`2416`	`}`
`2417`	`2417`
`2418`	`2418`	`impl RuleRunner for crate::rules::unicorn::no_invalid_fetch_options::NoInvalidFetchOptions {`
`2419`		`- const NODE_TYPES: Option<&AstTypesBitset> = None;`
	`2419`	`+ const NODE_TYPES: Option<&AstTypesBitset> =`
	`2420`	`+ Some(&AstTypesBitset::from_types(&[AstType::CallExpression, AstType::NewExpression]));`
`2420`	`2421`	`}`
`2421`	`2422`
`2422`	`2423`	`impl RuleRunner`
Original file line number	Diff line number	Diff line change
`@@ -59,29 +59,30 @@ declare_oxc_lint!(`
`59`	`59`
`60`	`60`	`impl Rule for NoInvalidFetchOptions {`
`61`	`61`	`fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {`
`62`		`- let arg = match node.kind() {`
	`62`	`+ match node.kind() {`
`63`	`63`	`AstKind::CallExpression(call_expr) => {`
`64`	`64`	`if !call_expr.callee.is_specific_id("fetch") \|\| call_expr.arguments.len() < 2 {`
`65`	`65`	`return;`
`66`	`66`	`}`
`67`	`67`
`68`		`- &call_expr.arguments[1]`
	`68`	`+ if let Argument::ObjectExpression(expr) = &call_expr.arguments[1]`
	`69`	`+ && let Some((method_name, body_span)) = is_invalid_fetch_options(expr, ctx)`
	`70`	`+ {`
	`71`	`+ ctx.diagnostic(no_invalid_fetch_options_diagnostic(body_span, &method_name));`
	`72`	`+ }`
`69`	`73`	`}`
`70`	`74`	`AstKind::NewExpression(new_expr) => {`
`71`	`75`	`if !is_new_expression(new_expr, &["Request"], Some(2), None) {`
`72`	`76`	`return;`
`73`	`77`	`}`
`74`	`78`
`75`		`- &new_expr.arguments[1]`
	`79`	`+ if let Argument::ObjectExpression(expr) = &new_expr.arguments[1]`
	`80`	`+ && let Some((method_name, body_span)) = is_invalid_fetch_options(expr, ctx)`
	`81`	`+ {`
	`82`	`+ ctx.diagnostic(no_invalid_fetch_options_diagnostic(body_span, &method_name));`
	`83`	`+ }`
`76`	`84`	`}`
`77`		`- _ => return,`
`78`		`- };`
`79`		`-`
`80`		`- let Argument::ObjectExpression(expr) = arg else { return };`
`81`		`- let result = is_invalid_fetch_options(expr, ctx);`
`82`		`-`
`83`		`- if let Some((method_name, body_span)) = result {`
`84`		`- ctx.diagnostic(no_invalid_fetch_options_diagnostic(body_span, &method_name));`
	`85`	`+ _ => {}`
`85`	`86`	`}`
`86`	`87`	`}`
`87`	`88`	`}`