fix(linter): false positive in typescript/explicit-function-return-type with satisfies (#10668)

camc314 · Boshen · commit 746b3188b67e · 2025-04-29T02:54:19.000Z
when working on #10667, i noticed these tests were missing from our suite. this PR ports over the tests and fixes them typescript/eslint PR typescript-eslint/typescript-eslint#10315
diff --git a/crates/oxc_linter/src/rules/typescript/explicit_function_return_type.rs b/crates/oxc_linter/src/rules/typescript/explicit_function_return_type.rs
@@ -420,6 +420,14 @@ impl ExplicitFunctionReturnType {
         let AstKind::ArrowFunctionExpression(func) = node.kind() else { return false };
         let Some(expr) = func.get_expression() else { return false };
 
+        let mut expr = expr;
+        loop {
+            expr = match expr {
+                Expression::TSSatisfiesExpression(e) => &e.expression,
+                _ => break,
+            };
+        }
+
         match expr {
             Expression::TSAsExpression(ts_expr) => {
                 let TSType::TSTypeReference(ts_type) = &ts_expr.type_annotation else {
@@ -606,7 +614,10 @@ fn is_typed_jsx(node: &AstNode) -> bool {
 }
 
 fn is_function(expr: &Expression) -> bool {
-    matches!(expr, Expression::ArrowFunctionExpression(_) | Expression::FunctionExpression(_))
+    matches!(
+        expr.get_inner_expression(),
+        Expression::ArrowFunctionExpression(_) | Expression::FunctionExpression(_)
+    )
 }
 
 fn ancestor_has_return_type<'a>(node: &AstNode<'a>, ctx: &LintContext<'a>) -> bool {
@@ -1145,9 +1156,56 @@ fn test() {
         ),
         (
             "
-        	new Promise(resolve => {});
-        	new Foo(1, () => {});
-        	",
+        	interface R {
+                type: string;
+                value: number;
+                }
+
+                const func = (value: number) => ({ type: 'X', value }) as const satisfies R;
+                ",
+            Some(
+                serde_json::json!([        {          "allowDirectConstAssertionInArrowFunctions": true,        },      ]),
+            ),
+            None,
+            None,
+        ),
+        (
+            "
+                interface R {
+                    type: string;
+                    value: number;
+                    }
+
+                    const func = (value: number) =>
+                    ({ type: 'X', value }) as const satisfies R satisfies R;
+                    ",
+            Some(
+                serde_json::json!([        {          "allowDirectConstAssertionInArrowFunctions": true,        },      ]),
+            ),
+            None,
+            None,
+        ),
+        (
+            "
+                    interface R {
+                        type: string;
+                        value: number;
+                        }
+
+                        const func = (value: number) =>
+                        ({ type: 'X', value }) as const satisfies R satisfies R satisfies R;
+                        ",
+            Some(
+                serde_json::json!([        {          "allowDirectConstAssertionInArrowFunctions": true,        },      ]),
+            ),
+            None,
+            None,
+        ),
+        (
+            "
+            new Promise(resolve => {});
+            new Foo(1, () => {});
+            ",
             Some(serde_json::json!([ { "allowTypedFunctionExpressions": true,  }, ])),
             None,
             None,
