fix(linter/no-unused-vars): Recognize parameters used in await/yield expressions within comma expressions (#10808)

magic-akari · web-flow · commit 5ce0a68dbc41 · 2025-05-05T10:06:11.000-04:00
- Closes: #10806
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs
@@ -236,6 +236,15 @@ fn test_vars_discarded_reads() {
         }
         foo(1)
         ",
+        // https://github.com/oxc-project/oxc/issues/10806
+        "export function f1(fn: () => Promise<void>) {
+            return async () => (await fn(), 1)
+        }",
+        "export function f2(fn: () => Promise<void>) {
+            return function* () {
+                return (yield fn(), 1);
+            }
+        }",
     ];
 
     let fail = vec![
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
@@ -607,9 +607,15 @@ impl<'a> Symbol<'_, 'a> {
                     }
                 }
                 (parent, AstKind::SequenceExpression(seq)) => {
-                    if matches!(parent, AstKind::CallExpression(_)) {
+                    if matches!(
+                        parent,
+                        AstKind::CallExpression(_)
+                            | AstKind::AwaitExpression(_)
+                            | AstKind::YieldExpression(_)
+                    ) {
                         continue;
                     }
+
                     debug_assert!(
                         !seq.expressions.is_empty(),
                         "empty SequenceExpressions should be a parse error."

Original file line number	Diff line number	Diff line change
`@@ -607,9 +607,15 @@ impl<'a> Symbol<'_, 'a> {`
`607`	`607`	`}`
`608`	`608`	`}`
`609`	`609`	`(parent, AstKind::SequenceExpression(seq)) => {`
`610`		`- if matches!(parent, AstKind::CallExpression(_)) {`
	`610`	`+ if matches!(`
	`611`	`+ parent,`
	`612`	`+ AstKind::CallExpression(_)`
	`613`	`+ \| AstKind::AwaitExpression(_)`
	`614`	`+ \| AstKind::YieldExpression(_)`
	`615`	`+ ) {`
`611`	`616`	`continue;`
`612`	`617`	`}`
	`618`	`+`
`613`	`619`	`debug_assert!(`
`614`	`620`	`!seq.expressions.is_empty(),`
`615`	`621`	`"empty SequenceExpressions should be a parse error."`