refactor(linter): move imports (#14085)

overlookmotel · overlookmotel · commit 56db8fa465c1 · 2025-09-24T14:54:34.000Z
Pure refactor. `run_external_rules` used to be feature-gated, so had a bunch of `use` statements in its body. But it's not feature-gated any more, so move them up to top level.

Also move a few imports in tests.
diff --git a/crates/oxc_linter/src/lib.rs b/crates/oxc_linter/src/lib.rs
@@ -1,16 +1,20 @@
 #![expect(clippy::self_named_module_files)] // for rules.rs
 
-use std::{path::Path, rc::Rc};
+use std::{
+    mem,
+    path::Path,
+    ptr::{self, NonNull},
+    rc::Rc,
+};
 
 use oxc_allocator::Allocator;
-use oxc_ast::ast_kind::AST_TYPE_MAX;
+use oxc_ast::{ast::Program, ast_kind::AST_TYPE_MAX};
 use oxc_ast_macros::ast;
 use oxc_ast_visit::utf8_to_utf16::Utf8ToUtf16;
 use oxc_data_structures::box_macros::boxed_array;
+use oxc_diagnostics::OxcDiagnostic;
 use oxc_semantic::AstNode;
-
-#[cfg(test)]
-mod tester;
+use oxc_span::Span;
 
 mod ast_util;
 mod config;
@@ -41,6 +45,9 @@ mod generated {
     mod rule_runner_impls;
 }
 
+#[cfg(test)]
+mod tester;
+
 pub use crate::{
     config::{
         BuiltinLintPlugins, Config, ConfigBuilderError, ConfigStore, ConfigStoreBuilder,
@@ -66,7 +73,7 @@ pub use crate::{
 use crate::{
     config::{LintConfig, OxlintEnv, OxlintGlobals, OxlintSettings},
     context::ContextHost,
-    fixer::{Fixer, Message},
+    fixer::{Fixer, Message, PossibleFixes},
     rules::RuleEnum,
     utils::iter_possible_jest_call_node,
 };
@@ -328,17 +335,6 @@ impl Linter {
         ctx_host: &mut Rc<ContextHost<'a>>,
         allocator: &'a Allocator,
     ) {
-        use std::{
-            mem,
-            ptr::{self, NonNull},
-        };
-
-        use oxc_ast::ast::Program;
-        use oxc_diagnostics::OxcDiagnostic;
-        use oxc_span::Span;
-
-        use crate::fixer::PossibleFixes;
-
         if external_rules.is_empty() {
             return;
         }
@@ -465,13 +461,14 @@ impl RawTransferMetadata {
 
 #[cfg(test)]
 mod test {
+    use std::fs;
+
+    use project_root::get_project_root;
+
     use super::Oxlintrc;
 
     #[test]
     fn test_schema_json() {
-        use std::fs;
-
-        use project_root::get_project_root;
         let path = get_project_root().unwrap().join("npm/oxlint/configuration_schema.json");
         let schema = schemars::schema_for!(Oxlintrc);
         let json = serde_json::to_string_pretty(&schema).unwrap();
