fix(span/estree): skip ModuleKind::Unambiguous varient for estree (#10146)

Dunqing · Dunqing · commit 52f2a409901a · 2025-04-03T16:47:07.000Z
close: #10139 The `ModuleKind::Unambiguous` can only occur in the parser stage, after being parsed, the `ModuleKind` certainly changes to `ModuleKind::Script` or `ModuleKind::Module`; otherwise is a bug in the parser.
diff --git a/crates/oxc_span/src/generated/derive_estree.rs b/crates/oxc_span/src/generated/derive_estree.rs
@@ -33,7 +33,7 @@ impl ESTree for ModuleKind {
         match self {
             Self::Script => JsonSafeString("script").serialize(serializer),
             Self::Module => JsonSafeString("module").serialize(serializer),
-            Self::Unambiguous => JsonSafeString("unambiguous").serialize(serializer),
+            Self::Unambiguous => unreachable!("This enum variant is skipped."),
         }
     }
 }
diff --git a/crates/oxc_span/src/source_type/mod.rs b/crates/oxc_span/src/source_type/mod.rs
@@ -58,6 +58,7 @@ pub enum ModuleKind {
     /// Note2: Dynamic import expression is not ESM syntax.
     ///
     /// See <https://babel.dev/docs/options#misc-options>
+    #[estree(skip)]
     Unambiguous = 2,
 }
 
diff --git a/napi/parser/deserialize-js.js b/napi/parser/deserialize-js.js
@@ -4122,8 +4122,6 @@ function deserializeModuleKind(pos) {
       return 'script';
     case 1:
       return 'module';
-    case 2:
-      return 'unambiguous';
     default:
       throw new Error(`Unexpected discriminant ${uint8[pos]} for ModuleKind`);
   }
diff --git a/napi/parser/deserialize-ts.js b/napi/parser/deserialize-ts.js
@@ -4197,8 +4197,6 @@ function deserializeModuleKind(pos) {
       return 'script';
     case 1:
       return 'module';
-    case 2:
-      return 'unambiguous';
     default:
       throw new Error(`Unexpected discriminant ${uint8[pos]} for ModuleKind`);
   }
diff --git a/npm/oxc-types/types.d.ts b/npm/oxc-types/types.d.ts
@@ -1484,7 +1484,7 @@ export interface Span {
   end: number;
 }
 
-export type ModuleKind = 'script' | 'module' | 'unambiguous';
+export type ModuleKind = 'script' | 'module';
 
 export interface Pattern extends Span {
   type: 'Pattern';

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ impl ESTree for ModuleKind {`
`33`	`33`	`match self {`
`34`	`34`	`Self::Script => JsonSafeString("script").serialize(serializer),`
`35`	`35`	`Self::Module => JsonSafeString("module").serialize(serializer),`
`36`		`- Self::Unambiguous => JsonSafeString("unambiguous").serialize(serializer),`
	`36`	`+ Self::Unambiguous => unreachable!("This enum variant is skipped."),`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ pub enum ModuleKind {`
`58`	`58`	`/// Note2: Dynamic import expression is not ESM syntax.`
`59`	`59`	`///`
`60`	`60`	`/// See <https://babel.dev/docs/options#misc-options>`
	`61`	`+ #[estree(skip)]`
`61`	`62`	`Unambiguous = 2,`
`62`	`63`	`}`
`63`	`64`
Original file line number	Diff line number	Diff line change
`@@ -4122,8 +4122,6 @@ function deserializeModuleKind(pos) {`
`4122`	`4122`	`return 'script';`
`4123`	`4123`	`case 1:`
`4124`	`4124`	`return 'module';`
`4125`		`- case 2:`
`4126`		`- return 'unambiguous';`
`4127`	`4125`	`default:`
`4128`	`4126`	throw new Error(`Unexpected discriminant ${uint8[pos]} for ModuleKind`);
`4129`	`4127`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4197,8 +4197,6 @@ function deserializeModuleKind(pos) {`
`4197`	`4197`	`return 'script';`
`4198`	`4198`	`case 1:`
`4199`	`4199`	`return 'module';`
`4200`		`- case 2:`
`4201`		`- return 'unambiguous';`
`4202`	`4200`	`default:`
`4203`	`4201`	throw new Error(`Unexpected discriminant ${uint8[pos]} for ModuleKind`);
`4204`	`4202`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1484,7 +1484,7 @@ export interface Span {`
`1484`	`1484`	`end: number;`
`1485`	`1485`	`}`
`1486`	`1486`
`1487`		`-export type ModuleKind = 'script' \| 'module' \| 'unambiguous';`
	`1487`	`+export type ModuleKind = 'script' \| 'module';`
`1488`	`1488`
`1489`	`1489`	`export interface Pattern extends Span {`
`1490`	`1490`	`type: 'Pattern';`