fix(linter/plugins, napi/parser): add parent field to FormalParameterRest and TSParameterProperty in TS type defs (#15337)

overlookmotel · overlookmotel · commit 40231a616a97 · 2025-11-05T16:23:53.000Z
Fix TS type defs. Add `parent` property to `FormalParameterRest` and `TSParameterProperty`, which both have their type definitions defined manually.
diff --git a/apps/oxlint/src-js/generated/types.d.ts b/apps/oxlint/src-js/generated/types.d.ts
@@ -673,6 +673,7 @@ export interface FormalParameterRest extends Span {
   optional?: boolean;
   typeAnnotation?: TSTypeAnnotation | null;
   value?: null;
+  parent: Node;
 }
 
 export type FormalParameter = {
@@ -687,6 +688,7 @@ export interface TSParameterProperty extends Span {
   parameter: FormalParameter;
   readonly: boolean;
   static: boolean;
+  parent: Node;
 }
 
 export interface FunctionBody extends Span {
diff --git a/apps/oxlint/src-js/plugins/scope.ts b/apps/oxlint/src-js/plugins/scope.ts
@@ -261,8 +261,6 @@ export function getScope(node: ESTree.Node): Scope {
       return scope.type === 'function-expression-name' ? scope.childScopes[0] : scope;
     }
 
-    // TODO: `TSParameterProperty` type should have a `parent` property.
-    // @ts-expect-error
     node = node.parent;
   } while (node !== null);
 
diff --git a/crates/oxc_ast/src/ast/js.rs b/crates/oxc_ast/src/ast/js.rs
@@ -1851,6 +1851,7 @@ pub enum FunctionType {
             optional?: boolean;
             typeAnnotation?: TSTypeAnnotation | null;
             value?: null;
+            parent/* IF !LINTER */?/* END IF */: Node;
         }
     "
 )]
@@ -1886,6 +1887,7 @@ pub struct FormalParameters<'a> {
             parameter: FormalParameter;
             readonly: boolean;
             static: boolean;
+            parent/* IF !LINTER */?/* END IF */: Node;
         }
     "
 )]
diff --git a/npm/oxc-types/types.d.ts b/npm/oxc-types/types.d.ts
@@ -669,6 +669,7 @@ export interface FormalParameterRest extends Span {
   optional?: boolean;
   typeAnnotation?: TSTypeAnnotation | null;
   value?: null;
+  parent?: Node;
 }
 
 export type FormalParameter = {
@@ -683,6 +684,7 @@ export interface TSParameterProperty extends Span {
   parameter: FormalParameter;
   readonly: boolean;
   static: boolean;
+  parent?: Node;
 }
 
 export interface FunctionBody extends Span {

Original file line number	Diff line number	Diff line change
`@@ -673,6 +673,7 @@ export interface FormalParameterRest extends Span {`
`673`	`673`	`optional?: boolean;`
`674`	`674`	`typeAnnotation?: TSTypeAnnotation \| null;`
`675`	`675`	`value?: null;`
	`676`	`+ parent: Node;`
`676`	`677`	`}`
`677`	`678`
`678`	`679`	`export type FormalParameter = {`
`@@ -687,6 +688,7 @@ export interface TSParameterProperty extends Span {`
`687`	`688`	`parameter: FormalParameter;`
`688`	`689`	`readonly: boolean;`
`689`	`690`	`static: boolean;`
	`691`	`+ parent: Node;`
`690`	`692`	`}`
`691`	`693`
`692`	`694`	`export interface FunctionBody extends Span {`
Original file line number	Diff line number	Diff line change
`@@ -261,8 +261,6 @@ export function getScope(node: ESTree.Node): Scope {`
`261`	`261`	`return scope.type === 'function-expression-name' ? scope.childScopes[0] : scope;`
`262`	`262`	`}`
`263`	`263`
`264`		- // TODO: `TSParameterProperty` type should have a `parent` property.
`265`		`- // @ts-expect-error`
`266`	`264`	`node = node.parent;`
`267`	`265`	`} while (node !== null);`
`268`	`266`
Original file line number	Diff line number	Diff line change
`@@ -1851,6 +1851,7 @@ pub enum FunctionType {`
`1851`	`1851`	`optional?: boolean;`
`1852`	`1852`	`typeAnnotation?: TSTypeAnnotation \| null;`
`1853`	`1853`	`value?: null;`
	`1854`	`+ parent/* IF !LINTER /?/ END IF */: Node;`
`1854`	`1855`	`}`
`1855`	`1856`	`"`
`1856`	`1857`	`)]`
`@@ -1886,6 +1887,7 @@ pub struct FormalParameters<'a> {`
`1886`	`1887`	`parameter: FormalParameter;`
`1887`	`1888`	`readonly: boolean;`
`1888`	`1889`	`static: boolean;`
	`1890`	`+ parent/* IF !LINTER /?/ END IF */: Node;`
`1889`	`1891`	`}`
`1890`	`1892`	`"`
`1891`	`1893`	`)]`
Original file line number	Diff line number	Diff line change
`@@ -669,6 +669,7 @@ export interface FormalParameterRest extends Span {`
`669`	`669`	`optional?: boolean;`
`670`	`670`	`typeAnnotation?: TSTypeAnnotation \| null;`
`671`	`671`	`value?: null;`
	`672`	`+ parent?: Node;`
`672`	`673`	`}`
`673`	`674`
`674`	`675`	`export type FormalParameter = {`
`@@ -683,6 +684,7 @@ export interface TSParameterProperty extends Span {`
`683`	`684`	`parameter: FormalParameter;`
`684`	`685`	`readonly: boolean;`
`685`	`686`	`static: boolean;`
	`687`	`+ parent?: Node;`
`686`	`688`	`}`
`687`	`689`
`688`	`690`	`export interface FunctionBody extends Span {`