fix(linter): false negative in jsx-a11y/aria-role (#11547)

camc314 · camc314 · commit 3952e0135a1a · 2025-06-07T14:45:25.000Z
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs b/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs
@@ -164,7 +164,9 @@ impl Rule for AriaRole {
                     Some(JSXAttributeValue::StringLiteral(str)) => {
                         let words_str = String::from(str.value.as_str());
                         let words = words_str.split_whitespace();
-                        if let Some(error_prop) = words.into_iter().find(|word| {
+                        if words_str.trim().is_empty() {
+                            ctx.diagnostic(aria_role_diagnostic(str.span, ""));
+                        } else if let Some(error_prop) = words.into_iter().find(|word| {
                             !VALID_ARIA_ROLES.contains(word)
                                 && !self.allowed_invalid_roles.contains(&(*word).to_string())
                         }) {
@@ -237,7 +239,7 @@ fn test() {
         ("<div role='datepicker'></div>", None, None),
         ("<div role='range'></div>", None, None),
         ("<div role='Button'></div>", None, None),
-        ("<div role='></div>", None, None),
+        ("<div role=''></div>", None, None),
         ("<div role='tabpanel row foobar'></div>", None, None),
         ("<div role='tabpanel row range'></div>", None, None),
         ("<div role='doc-endnotes range'></div>", None, None),
diff --git a/crates/oxc_linter/src/snapshots/jsx_a11y_aria_role.snap b/crates/oxc_linter/src/snapshots/jsx_a11y_aria_role.snap
@@ -29,11 +29,12 @@ source: crates/oxc_linter/src/tester.rs
    ╰────
   help: Set a valid, non-abstract ARIA role for element with ARIA, `Button` is an invalid aria role
 
-  × Unterminated string
+  ⚠ eslint-plugin-jsx-a11y(aria-role): Elements with ARIA roles must use a valid, non-abstract ARIA role.
    ╭─[aria_role.tsx:1:11]
- 1 │ <div role='></div>
-   ·           ────────
+ 1 │ <div role=''></div>
+   ·           ──
    ╰────
+  help: Set a valid, non-abstract ARIA role for element with ARIA
 
   ⚠ eslint-plugin-jsx-a11y(aria-role): Elements with ARIA roles must use a valid, non-abstract ARIA role.
    ╭─[aria_role.tsx:1:11]
