fix(linter): reword diagnostic message for no-control-regex (#10993)

camc314 · camc314 · commit 39063ce30876 · 2025-05-13T08:49:38.000Z
diff --git a/crates/oxc_language_server/src/snapshots/fixtures_linter_regexp_feature@index.ts.snap b/crates/oxc_language_server/src/snapshots/fixtures_linter_regexp_feature@index.ts.snap
@@ -4,7 +4,7 @@ input_file: crates/oxc_language_server/fixtures/linter/regexp_feature/index.ts
 ---
 code: "eslint(no-control-regex)"
 code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-control-regex.html"
-message: "Unexpected control character\nhelp: '\\u0000' is not a valid control character."
+message: "Unexpected control character\nhelp: '\\u0000' is a control character."
 range: Range { start: Position { line: 1, character: 13 }, end: Position { line: 1, character: 32 } }
 related_information[0].message: ""
 related_information[0].location.uri: "file://<variable>/fixtures/linter/regexp_feature/index.ts"
diff --git a/crates/oxc_linter/src/rules/eslint/no_control_regex.rs b/crates/oxc_linter/src/rules/eslint/no_control_regex.rs
@@ -40,7 +40,7 @@ fn no_control_regex_diagnostic(control_chars: &[Character], span: Span) -> OxcDi
         let regexes = other_chars.iter().join(", ");
         writeln!(
             help,
-            "'{regexes}' {} not {}valid control character{}.",
+            "'{regexes}' {} {}control character{}.",
             if other_chars.len() > 1 { "are" } else { "is" },
             if other_chars.len() > 1 { "" } else { "a " },
             if other_chars.len() > 1 { "s" } else { "" },
@@ -52,7 +52,7 @@ fn no_control_regex_diagnostic(control_chars: &[Character], span: Span) -> OxcDi
         let regexes = octal_chars.iter().join(", ");
         writeln!(
             help,
-            "'{regexes}' {} not {}valid control character{}. They look like backreferences, but there {} no corresponding capture group{}. If you are trying to match the octal character, consider using '\\xNN' or '\\u00NN' instead.",
+            "'{regexes}' {} {}control character{}. They look like backreferences, but there {} no corresponding capture group{}.",
             if octal_chars.len() > 1 { "are" } else { "is" },
             if octal_chars.len() > 1 { "" } else { "a " },
             if octal_chars.len() > 1 { "s" } else { "" },
@@ -62,10 +62,8 @@ fn no_control_regex_diagnostic(control_chars: &[Character], span: Span) -> OxcDi
     }
 
     if !null_chars.is_empty() {
-        writeln!(
-        help,
-        "'\\0' matches the null character (U+0000), which is a control character. If you intend to match the null character, consider using '\\x00' or '\\u0000' for clarity."
-        ).unwrap();
+        writeln!(help, "'\\0' matches the null character (U+0000), which is a control character.")
+            .unwrap();
     }
 
     debug_assert!(!help.is_empty());
diff --git a/crates/oxc_linter/src/snapshots/eslint_no_control_regex.snap b/crates/oxc_linter/src/snapshots/eslint_no_control_regex.snap
diff --git a/crates/oxc_linter/src/snapshots/eslint_no_control_regex@capture-group-indexing.snap b/crates/oxc_linter/src/snapshots/eslint_no_control_regex@capture-group-indexing.snap
@@ -6,25 +6,25 @@ source: crates/oxc_linter/src/tester.rs
  1 │ const r = /\0/;
    ·           ────
    ╰────
-  help: '\0' matches the null character (U+0000), which is a control character. If you intend to match the null character, consider using '\x00' or '\u0000' for clarity.
+  help: '\0' matches the null character (U+0000), which is a control character.
 
   ⚠ eslint(no-control-regex): Unexpected control character
    ╭─[no_control_regex.tsx:1:11]
  1 │ const r = /[a-z]\1/;
    ·           ─────────
    ╰────
-  help: '\1' is not a valid control character. They look like backreferences, but there is no corresponding capture group. If you are trying to match the octal character, consider using '\xNN' or '\u00NN' instead.
+  help: '\1' is a control character. They look like backreferences, but there is no corresponding capture group.
 
   ⚠ eslint(no-control-regex): Unexpected control character
    ╭─[no_control_regex.tsx:1:11]
  1 │ const r = /([a-z])\2/;
    ·           ───────────
    ╰────
-  help: '\2' is not a valid control character. They look like backreferences, but there is no corresponding capture group. If you are trying to match the octal character, consider using '\xNN' or '\u00NN' instead.
+  help: '\2' is a control character. They look like backreferences, but there is no corresponding capture group.
 
   ⚠ eslint(no-control-regex): Unexpected control character
    ╭─[no_control_regex.tsx:1:11]
  1 │ const r = /([a-z])\0/;
    ·           ───────────
    ╰────
-  help: '\0' matches the null character (U+0000), which is a control character. If you intend to match the null character, consider using '\x00' or '\u0000' for clarity.
+  help: '\0' matches the null character (U+0000), which is a control character.
