fix(linter): skip no-unused-vars on astro files (#11303)

camc314 · camc314 · commit 348ad97ca61f · 2025-05-26T17:38:11.000Z
fixes #11301
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/mod.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/mod.rs
@@ -215,12 +215,15 @@ impl Rule for NoUnusedVars {
     }
 
     fn should_run(&self, ctx: &ContextHost) -> bool {
-        // ignore .d.ts and vue/svelte files.
+        // ignore .d.ts and vue/svelte/astro files.
         // 1. declarations have side effects (they get merged together)
-        // 2. vue/svelte scripts declare variables that get used in the template, which
+        // 2. vue/svelte/astro scripts declare variables that get used in the template, which
         //    we can't detect
         !ctx.source_type().is_typescript_definition()
-            && !ctx.file_path().extension().is_some_and(|ext| ext == "vue" || ext == "svelte")
+            && !ctx
+                .file_path()
+                .extension()
+                .is_some_and(|ext| ext == "vue" || ext == "svelte" || ext == "astro")
     }
 }
 
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs
@@ -1,5 +1,7 @@
 //! Test cases created by oxc maintainers
 
+use std::path::PathBuf;
+
 use serde_json::json;
 
 use super::NoUnusedVars;
@@ -1310,6 +1312,43 @@ fn test_report_vars_only_used_as_types() {
         .test();
 }
 
+#[test]
+fn test_should_run() {
+    let pass = vec![
+        (
+            r#"<script setup lang="ts"> import * as vue from 'vue' </script>"#,
+            None,
+            None,
+            Some(PathBuf::from("src/foo/bar.vue")),
+        ),
+        (
+            r"---
+import Welcome from '../components/Welcome.astro';
+import Layout from '../layouts/Layout.astro';
+---
+<Layout>
+	<Welcome />
+</Layout>",
+            None,
+            None,
+            Some(PathBuf::from("src/foo/bar.astro")),
+        ),
+        (
+            r"<script>
+	            import Nested from './Nested.svelte';
+            </script>
+            <Nested answer={42} />",
+            None,
+            None,
+            Some(PathBuf::from("src/foo/bar.svelte")),
+        ),
+    ];
+
+    Tester::new(NoUnusedVars::NAME, NoUnusedVars::PLUGIN, pass, vec![])
+        .intentionally_allow_no_fix_tests()
+        .test();
+}
+
 // #[test]
 // fn test_template() {
 //     let pass = vec![];

Original file line number	Diff line number	Diff line change
`@@ -215,12 +215,15 @@ impl Rule for NoUnusedVars {`
`215`	`215`	`}`
`216`	`216`
`217`	`217`	`fn should_run(&self, ctx: &ContextHost) -> bool {`
`218`		`- // ignore .d.ts and vue/svelte files.`
	`218`	`+ // ignore .d.ts and vue/svelte/astro files.`
`219`	`219`	`// 1. declarations have side effects (they get merged together)`
`220`		`- // 2. vue/svelte scripts declare variables that get used in the template, which`
	`220`	`+ // 2. vue/svelte/astro scripts declare variables that get used in the template, which`
`221`	`221`	`// we can't detect`
`222`	`222`	`!ctx.source_type().is_typescript_definition()`
`223`		`- && !ctx.file_path().extension().is_some_and(\|ext\| ext == "vue" \|\| ext == "svelte")`
	`223`	`+ && !ctx`
	`224`	`+ .file_path()`
	`225`	`+ .extension()`
	`226`	`+ .is_some_and(\|ext\| ext == "vue" \|\| ext == "svelte" \|\| ext == "astro")`
`224`	`227`	`}`
`225`	`228`	`}`
`226`	`229`