fix(linter): false positive in eslint/no-unused-vars when calling inside sequence expression (#10646)

ulrichstark · web-flow · commit 344ef88f7460 · 2025-04-27T19:15:46.000-07:00
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs
@@ -73,6 +73,7 @@ fn test_vars_simple() {
         ("console.log(function a() {} ? b : c)", None),
         ("console.log(a ? function b() {} : c)", None),
         ("console.log(a ? b : function c() {})", None),
+        ("cb => (cb(), 0)", None),
     ];
     let fail = vec![
         ("let a = 1", None),
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
@@ -600,6 +600,9 @@ impl<'a> Symbol<'_, 'a> {
                     }
                 }
                 (parent, AstKind::SequenceExpression(seq)) => {
+                    if matches!(parent, AstKind::CallExpression(_)) {
+                        continue;
+                    }
                     debug_assert!(
                         !seq.expressions.is_empty(),
                         "empty SequenceExpressions should be a parse error."

Original file line number	Diff line number	Diff line change
`@@ -600,6 +600,9 @@ impl<'a> Symbol<'_, 'a> {`
`600`	`600`	`}`
`601`	`601`	`}`
`602`	`602`	`(parent, AstKind::SequenceExpression(seq)) => {`
	`603`	`+ if matches!(parent, AstKind::CallExpression(_)) {`
	`604`	`+ continue;`
	`605`	`+ }`
`603`	`606`	`debug_assert!(`
`604`	`607`	`!seq.expressions.is_empty(),`
`605`	`608`	`"empty SequenceExpressions should be a parse error."`