feat(linter): introduce denyWarnings config options (#19926)

camc314 · camc314 · commit 2919313574b9 · 2026-03-02T13:25:43.000Z
diff --git a/apps/oxlint/fixtures/linter/config-deny-warnings-false.json b/apps/oxlint/fixtures/linter/config-deny-warnings-false.json
@@ -0,0 +1,8 @@
+{
+  "rules": {
+    "no-debugger": "warn"
+  },
+  "options": {
+    "denyWarnings": false
+  }
+}
diff --git a/apps/oxlint/fixtures/linter/config-deny-warnings.json b/apps/oxlint/fixtures/linter/config-deny-warnings.json
@@ -0,0 +1,8 @@
+{
+  "rules": {
+    "no-debugger": "warn"
+  },
+  "options": {
+    "denyWarnings": true
+  }
+}
diff --git a/apps/oxlint/src-js/package/config.generated.ts b/apps/oxlint/src-js/package/config.generated.ts
@@ -312,6 +312,18 @@ export interface OxlintGlobals {
  * Options for the linter.
  */
 export interface OxlintOptions {
+  /**
+   * Ensure warnings produce a non-zero exit code.
+   *
+   * Equivalent to passing `--deny-warnings` on the CLI.
+   */
+  denyWarnings?: boolean | null;
+  /**
+   * Specify a warning threshold. Exits with an error status if warnings exceed this value.
+   *
+   * Equivalent to passing `--max-warnings` on the CLI.
+   */
+  maxWarnings?: number | null;
   /**
    * Enable rules that require type information.
    *
@@ -324,12 +336,6 @@ export interface OxlintOptions {
    * Equivalent to passing `--type-check` on the CLI.
    */
   typeCheck?: boolean | null;
-  /**
-   * Specify a warning threshold. Exits with an error status if warnings exceed this value.
-   *
-   * Equivalent to passing `--max-warnings` on the CLI.
-   */
-  maxWarnings?: number | null;
 }
 export interface OxlintOverride {
   /**
diff --git a/apps/oxlint/src/config_loader.rs b/apps/oxlint/src/config_loader.rs
@@ -387,6 +387,12 @@ impl<'a> ConfigLoader<'a> {
                         .push(ConfigLoadError::Diagnostic(nested_type_check_not_supported(&path)));
                     continue;
                 }
+                if builder.deny_warnings().is_some() {
+                    errors.push(ConfigLoadError::Diagnostic(nested_deny_warnings_not_supported(
+                        &path,
+                    )));
+                    continue;
+                }
                 if builder.max_warnings().is_some() {
                     errors.push(ConfigLoadError::Diagnostic(nested_max_warnings_not_supported(
                         &path,
@@ -655,6 +661,14 @@ fn nested_type_check_not_supported(path: &Path) -> OxcDiagnostic {
     .with_help("Move `options.typeCheck` to the root configuration file.")
 }
 
+fn nested_deny_warnings_not_supported(path: &Path) -> OxcDiagnostic {
+    OxcDiagnostic::error(format!(
+        "The `options.denyWarnings` option is only supported in the root config, but it was found in {}.",
+        path.display()
+    ))
+    .with_help("Move `options.denyWarnings` to the root configuration file.")
+}
+
 fn nested_max_warnings_not_supported(path: &Path) -> OxcDiagnostic {
     OxcDiagnostic::error(format!(
         "The `options.maxWarnings` option is only supported in the root config, but it was found in {}.",
@@ -795,6 +809,21 @@ mod test {
         assert!(matches!(errors[0], ConfigLoadError::Diagnostic(_)));
     }
 
+    #[test]
+    fn test_nested_json_config_rejects_deny_warnings() {
+        let root_dir = tempfile::tempdir().unwrap();
+        let nested_path = root_dir.path().join("nested/.oxlintrc.json");
+        std::fs::create_dir_all(nested_path.parent().unwrap()).unwrap();
+        std::fs::write(&nested_path, r#"{ "options": { "denyWarnings": true } }"#).unwrap();
+
+        let mut external_plugin_store = ExternalPluginStore::new(false);
+        let mut loader = ConfigLoader::new(None, &mut external_plugin_store, &[], None);
+        let (_configs, errors) = loader
+            .load_discovered_with_root_dir(root_dir.path(), [DiscoveredConfig::Json(nested_path)]);
+        assert_eq!(errors.len(), 1);
+        assert!(matches!(errors[0], ConfigLoadError::Diagnostic(_)));
+    }
+
     #[cfg(feature = "napi")]
     #[test]
     fn test_root_oxlint_config_ts_allows_type_aware() {
@@ -895,6 +924,36 @@ mod test {
         assert!(matches!(errors[0], ConfigLoadError::Diagnostic(_)));
     }
 
+    #[cfg(feature = "napi")]
+    #[test]
+    fn test_nested_oxlint_config_ts_rejects_deny_warnings() {
+        let root_dir = tempfile::tempdir().unwrap();
+        let nested_path = root_dir.path().join("nested/oxlint.config.ts");
+        std::fs::create_dir_all(nested_path.parent().unwrap()).unwrap();
+        std::fs::write(&nested_path, "export default {};").unwrap();
+
+        let mut external_plugin_store = ExternalPluginStore::new(false);
+        let mut loader = ConfigLoader::new(None, &mut external_plugin_store, &[], None);
+
+        let js_loader = make_js_loader(move |paths| {
+            Ok(paths
+                .into_iter()
+                .map(|path| {
+                    let path = PathBuf::from(path);
+                    let mut config = make_js_config(path.clone(), None, None).config;
+                    config.options.deny_warnings = Some(true);
+                    JsConfigResult { path, config }
+                })
+                .collect())
+        });
+        loader = loader.with_js_config_loader(Some(&js_loader));
+
+        let (_configs, errors) = loader
+            .load_discovered_with_root_dir(root_dir.path(), [DiscoveredConfig::Js(nested_path)]);
+        assert_eq!(errors.len(), 1);
+        assert!(matches!(errors[0], ConfigLoadError::Diagnostic(_)));
+    }
+
     #[cfg(feature = "napi")]
     #[test]
     fn test_nested_oxlint_config_ts_rejects_type_aware_from_extends() {
diff --git a/apps/oxlint/src/lint.rs b/apps/oxlint/src/lint.rs
@@ -341,6 +341,7 @@ impl CliRunner {
         let config_store = ConfigStore::new(lint_config, nested_configs, external_plugin_store);
         let type_aware = self.options.type_aware || config_store.type_aware_enabled();
         let type_check = self.options.type_check || config_store.type_check_enabled();
+        let deny_warnings = warning_options.deny_warnings || config_store.deny_warnings();
         let max_warnings = warning_options.max_warnings.or(config_store.max_warnings());
 
         let report_unused_directives = match inline_config_options.report_unused_directives {
@@ -443,7 +444,7 @@ impl CliRunner {
 
         if diagnostic_result.errors_count() > 0 {
             CliRunResult::LintFoundErrors
-        } else if warning_options.deny_warnings && diagnostic_result.warnings_count() > 0 {
+        } else if deny_warnings && diagnostic_result.warnings_count() > 0 {
             CliRunResult::LintNoWarningsAllowed
         } else if diagnostic_result.max_warnings_exceeded() {
             CliRunResult::LintMaxWarningsExceeded
@@ -1329,6 +1330,18 @@ mod test {
         Tester::new().with_cwd("fixtures/linter".into()).test_and_snapshot(args);
     }
 
+    #[test]
+    fn test_deny_warnings_via_config_file() {
+        let args = &["-c", "config-deny-warnings.json", "debugger.js"];
+        Tester::new().with_cwd("fixtures/linter".into()).test_and_snapshot(args);
+    }
+
+    #[test]
+    fn test_deny_warnings_overridden_by_cli_flag() {
+        let args = &["--deny-warnings", "-c", "config-deny-warnings-false.json", "debugger.js"];
+        Tester::new().with_cwd("fixtures/linter".into()).test_and_snapshot(args);
+    }
+
     #[test]
     #[cfg(not(target_endian = "big"))]
     fn test_tsgolint_no_typescript_files() {
diff --git a/apps/oxlint/src/snapshots/fixtures__linter_--deny-warnings -c config-deny-warnings-false.json debugger.js@oxlint.snap b/apps/oxlint/src/snapshots/fixtures__linter_--deny-warnings -c config-deny-warnings-false.json debugger.js@oxlint.snap
@@ -0,0 +1,20 @@
+---
+source: apps/oxlint/src/tester.rs
+---
+########## 
+arguments: --deny-warnings -c config-deny-warnings-false.json debugger.js
+working directory: fixtures/linter
+----------
+
+  ! eslint(no-debugger): `debugger` statement is not allowed
+   ,-[debugger.js:1:1]
+ 1 | debugger;
+   : ^^^^^^^^^
+   `----
+  help: Remove the debugger statement
+
+Found 1 warning and 0 errors.
+Finished in <variable>ms on 1 file with 93 rules using 1 threads.
+----------
+CLI result: LintNoWarningsAllowed
+----------
diff --git a/apps/oxlint/src/snapshots/fixtures__linter_-c config-deny-warnings.json debugger.js@oxlint.snap b/apps/oxlint/src/snapshots/fixtures__linter_-c config-deny-warnings.json debugger.js@oxlint.snap
@@ -0,0 +1,20 @@
+---
+source: apps/oxlint/src/tester.rs
+---
+########## 
+arguments: -c config-deny-warnings.json debugger.js
+working directory: fixtures/linter
+----------
+
+  ! eslint(no-debugger): `debugger` statement is not allowed
+   ,-[debugger.js:1:1]
+ 1 | debugger;
+   : ^^^^^^^^^
+   `----
+  help: Remove the debugger statement
+
+Found 1 warning and 0 errors.
+Finished in <variable>ms on 1 file with 93 rules using 1 threads.
+----------
+CLI result: LintNoWarningsAllowed
+----------
diff --git a/apps/oxlint/test/fixtures/js_config_dynamic_deny_warnings/files/test.js b/apps/oxlint/test/fixtures/js_config_dynamic_deny_warnings/files/test.js
@@ -0,0 +1 @@
+debugger;
diff --git a/apps/oxlint/test/fixtures/js_config_dynamic_deny_warnings/output.snap.md b/apps/oxlint/test/fixtures/js_config_dynamic_deny_warnings/output.snap.md
@@ -0,0 +1,19 @@
+# Exit code
+1
+
+# stdout
+```
+  ! eslint(no-debugger): `debugger` statement is not allowed
+   ,-[files/test.js:1:1]
+ 1 | debugger;
+   : ^^^^^^^^^
+   `----
+  help: Remove the debugger statement
+
+Found 1 warning and 0 errors.
+Finished in Xms on 1 file with 1 rules using X threads.
+```
+
+# stderr
+```
+```
diff --git a/apps/oxlint/test/fixtures/js_config_dynamic_deny_warnings/oxlint.config.ts b/apps/oxlint/test/fixtures/js_config_dynamic_deny_warnings/oxlint.config.ts
@@ -0,0 +1,13 @@
+import { defineConfig } from "#oxlint";
+
+const options = {
+  denyWarnings: true,
+};
+
+export default defineConfig({
+  categories: { correctness: "off" },
+  rules: {
+    "no-debugger": "warn",
+  },
+  options,
+});
diff --git a/crates/oxc_linter/fixtures/extends_config/options/deny_warnings_false.json b/crates/oxc_linter/fixtures/extends_config/options/deny_warnings_false.json
@@ -0,0 +1,5 @@
+{
+  "options": {
+    "denyWarnings": false
+  }
+}
diff --git a/crates/oxc_linter/fixtures/extends_config/options/deny_warnings_true.json b/crates/oxc_linter/fixtures/extends_config/options/deny_warnings_true.json
@@ -0,0 +1,5 @@
+{
+  "options": {
+    "denyWarnings": true
+  }
+}
diff --git a/crates/oxc_linter/src/config/config_builder.rs b/crates/oxc_linter/src/config/config_builder.rs
@@ -342,6 +342,11 @@ impl ConfigStoreBuilder {
         self.config.options.type_check
     }
 
+    #[inline]
+    pub fn deny_warnings(&self) -> Option<bool> {
+        self.config.options.deny_warnings
+    }
+
     #[inline]
     pub fn max_warnings(&self) -> Option<usize> {
         self.config.options.max_warnings
@@ -1421,6 +1426,26 @@ mod test {
         );
         assert_eq!(config.base.config.options.type_check, Some(false));
 
+        let config = config_store_from_str(
+            r#"{ "extends": ["fixtures/extends_config/options/deny_warnings_true.json"] }"#,
+        );
+        assert_eq!(config.base.config.options.deny_warnings, Some(true));
+
+        let config = config_store_from_str(
+            r#"
+            {
+                "extends": ["fixtures/extends_config/options/deny_warnings_true.json"],
+                "options": {"denyWarnings": false }
+            }
+            "#,
+        );
+        assert_eq!(config.base.config.options.deny_warnings, Some(false));
+
+        let config = config_store_from_str(
+            r#"{ "extends": ["fixtures/extends_config/options/deny_warnings_false.json"] }"#,
+        );
+        assert_eq!(config.base.config.options.deny_warnings, Some(false));
+
         let config = config_store_from_str(
             r#"{ "extends": ["fixtures/extends_config/options/max_warnings_10.json"] }"#,
         );
diff --git a/crates/oxc_linter/src/config/config_store.rs b/crates/oxc_linter/src/config/config_store.rs
@@ -330,6 +330,11 @@ impl ConfigStore {
         self.base.base.config.options.type_check.unwrap_or(false)
     }
 
+    /// Whether warnings should produce a non-zero exit code.
+    pub fn deny_warnings(&self) -> bool {
+        self.base.base.config.options.deny_warnings.unwrap_or(false)
+    }
+
     /// Max warnings configured in the root config.
     pub fn max_warnings(&self) -> Option<usize> {
         self.base.base.config.options.max_warnings
@@ -1215,6 +1220,35 @@ mod test {
         assert!(!store.type_check_enabled());
     }
 
+    #[test]
+    fn test_deny_warnings_enabled_from_root_config() {
+        let base = Config::new(
+            vec![],
+            vec![],
+            OxlintCategories::default(),
+            LintConfig {
+                options: OxlintOptions { deny_warnings: Some(true), ..OxlintOptions::default() },
+                ..LintConfig::default()
+            },
+            ResolvedOxlintOverrides::new(vec![]),
+        );
+        let store = ConfigStore::new(base, FxHashMap::default(), ExternalPluginStore::default());
+        assert!(store.deny_warnings());
+    }
+
+    #[test]
+    fn test_deny_warnings_disabled_by_default() {
+        let base = Config::new(
+            vec![],
+            vec![],
+            OxlintCategories::default(),
+            LintConfig::default(),
+            ResolvedOxlintOverrides::new(vec![]),
+        );
+        let store = ConfigStore::new(base, FxHashMap::default(), ExternalPluginStore::default());
+        assert!(!store.deny_warnings());
+    }
+
     #[test]
     fn test_max_warnings_from_root_config() {
         let base = Config::new(
diff --git a/crates/oxc_linter/src/config/oxlintrc.rs b/crates/oxc_linter/src/config/oxlintrc.rs
diff --git a/npm/oxlint/configuration_schema.json b/npm/oxlint/configuration_schema.json
diff --git a/tasks/website_linter/src/snapshots/schema_json.snap b/tasks/website_linter/src/snapshots/schema_json.snap
diff --git a/tasks/website_linter/src/snapshots/schema_markdown.snap b/tasks/website_linter/src/snapshots/schema_markdown.snap
