fix(semantic): distinguish class private elements (#11044)

magic-akari · Dunqing · web-flow · commit 126ae75f5bf8 · 2025-05-15T16:27:16.000+08:00
- Fix: #11039 --------- Co-authored-by: Dunqing <dengqing0821@gmail.com>
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_private_class_members.rs b/crates/oxc_linter/src/rules/eslint/no_unused_private_class_members.rs
@@ -295,6 +295,19 @@ fn test() {
                 this.#x = 1;
             }
         }",
+        r"type Callback<T> = () => Promise<T> | T;
+
+         export class Issue_11039<T> {
+            load: () => Promise<T>;
+
+            constructor(callback: Callback<T>) {
+                this.load = () => this.#load(callback);
+            }
+
+            async #load(callback: Callback<T>) {
+                callback;
+            }
+         }",
     ];
 
     let fail = vec![
diff --git a/crates/oxc_semantic/src/class/builder.rs b/crates/oxc_semantic/src/class/builder.rs
@@ -106,7 +106,11 @@ impl<'a> ClassTableBuilder<'a> {
             if matches!(parent_kind, AstKind::PrivateInExpression(_) | AstKind::MemberExpression(_))
             {
                 if let Some(class_id) = self.current_class_id {
-                    let element_ids = self.classes.get_element_ids(class_id, &ident.name);
+                    let element_ids = self.classes.get_element_ids(
+                        class_id,
+                        &ident.name,
+                        /* is_private */ true,
+                    );
 
                     let reference = PrivateIdentifierReference::new(
                         current_node_id,
diff --git a/crates/oxc_semantic/src/class/table.rs b/crates/oxc_semantic/src/class/table.rs
@@ -78,10 +78,15 @@ impl<'a> ClassTable<'a> {
         self.declarations[class_id]
     }
 
-    pub fn get_element_ids(&self, class_id: ClassId, name: &str) -> Vec<ElementId> {
+    pub fn get_element_ids(
+        &self,
+        class_id: ClassId,
+        name: &str,
+        is_private: bool,
+    ) -> Vec<ElementId> {
         let mut element_ids = vec![];
         for (element_id, element) in self.elements[class_id].iter_enumerated() {
-            if element.name == name {
+            if element.name == name && element.is_private == is_private {
                 element_ids.push(element_id);
 
                 // Property or Accessor only has 1 element
