fix(linter): improve diagnostic message for no-unsafe-declaration-merging (#11508)

camc314 · camc314 · commit 0de0c9c89f1d · 2025-06-06T09:27:56.000Z
diff --git a/crates/oxc_linter/src/rules/typescript/no_unsafe_declaration_merging.rs b/crates/oxc_linter/src/rules/typescript/no_unsafe_declaration_merging.rs
@@ -12,7 +12,7 @@ use crate::{
 
 fn no_unsafe_declaration_merging_diagnostic(span: Span, span1: Span) -> OxcDiagnostic {
     OxcDiagnostic::warn("Unsafe declaration merging between classes and interfaces.")
-        .with_help("The TypeScript compiler doesn't check whether properties are initialized, which can cause lead to TypeScript not detecting code that will cause runtime errors.")
+        .with_help("The TypeScript compiler doesn't check whether properties are initialized, which can lead to TypeScript not detecting code that will cause runtime errors.")
         .with_labels([span, span1])
 }
 
@@ -27,7 +27,7 @@ declare_oxc_lint!(
     /// ### Why is this bad?
     ///
     /// Declaration merging between classes and interfaces is unsafe.
-    /// The TypeScript compiler doesn't check whether properties are initialized, which can cause lead to TypeScript not detecting code that will cause runtime errors.
+    /// The TypeScript compiler doesn't check whether properties are initialized, which can lead to TypeScript not detecting code that will cause runtime errors.
     ///
     /// ### Examples
     ///
diff --git a/crates/oxc_linter/src/snapshots/typescript_no_unsafe_declaration_merging.snap b/crates/oxc_linter/src/snapshots/typescript_no_unsafe_declaration_merging.snap
@@ -10,7 +10,7 @@ source: crates/oxc_linter/src/tester.rs
    ·                   ───
  4 │                   
    ╰────
-  help: The TypeScript compiler doesn't check whether properties are initialized, which can cause lead to TypeScript not detecting code that will cause runtime errors.
+  help: The TypeScript compiler doesn't check whether properties are initialized, which can lead to TypeScript not detecting code that will cause runtime errors.
 
   ⚠ typescript-eslint(no-unsafe-declaration-merging): Unsafe declaration merging between classes and interfaces.
    ╭─[no_unsafe_declaration_merging.tsx:2:19]
@@ -21,7 +21,7 @@ source: crates/oxc_linter/src/tester.rs
    ·                               ───
  4 │                           
    ╰────
-  help: The TypeScript compiler doesn't check whether properties are initialized, which can cause lead to TypeScript not detecting code that will cause runtime errors.
+  help: The TypeScript compiler doesn't check whether properties are initialized, which can lead to TypeScript not detecting code that will cause runtime errors.
 
   ⚠ typescript-eslint(no-unsafe-declaration-merging): Unsafe declaration merging between classes and interfaces.
    ╭─[no_unsafe_declaration_merging.tsx:3:25]
@@ -32,4 +32,4 @@ source: crates/oxc_linter/src/tester.rs
    ·                             ───
  5 │                     }
    ╰────
-  help: The TypeScript compiler doesn't check whether properties are initialized, which can cause lead to TypeScript not detecting code that will cause runtime errors.
+  help: The TypeScript compiler doesn't check whether properties are initialized, which can lead to TypeScript not detecting code that will cause runtime errors.
