fix(remote): avoid false first-time contributors when tag timestamp missing#1348
Merged
fix(remote): avoid false first-time contributors when tag timestamp missing#1348
Conversation
1 task
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
+ Coverage 43.40% 43.42% +0.03%
==========================================
Files 23 23
Lines 2247 2248 +1
==========================================
+ Hits 975 976 +1
Misses 1272 1272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Here is full log from branch, |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
--unreleasedis combined with--tagon a branch where the tag/gcs commit isn't in the fetched remote commits, the release commit timestamp can't be resolved.The "first-time contributor" logic then filters against a missing timestamp and classifies too many contributors as new.
This causes the New Contributors section to include past contributors.
Motivation and Context
Potential fix for #1347
How Has This Been Tested?
Locally
Types of Changes
Checklist:
cargo +nightly fmt --allcargo clippy --tests --verbose -- -D warningscargo test